After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 657358 - Screen turns white when lock dialog is cancelled
Screen turns white when lock dialog is cancelled
Status: RESOLVED FIXED
Product: gnome-screensaver
Classification: Deprecated
Component: general
3.1.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-screensaver maintainers
gnome-screensaver maintainers
Depends on:
Blocks:
 
 
Reported: 2011-08-25 17:29 UTC by Marc Deslauriers
Modified: 2011-08-26 12:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed patch (896 bytes, patch)
2011-08-25 17:30 UTC, Marc Deslauriers 		none Details | Review
Properly clear to black when cancelling unlock (1.29 KB, patch)
2011-08-26 12:11 UTC, Matthias Clasen 		committed Details | Review
gs-window-x11: Properly set background to black (943 bytes, patch)
2011-08-26 12:11 UTC, Matthias Clasen 		committed Details | Review

Description Marc Deslauriers 2011-08-25 17:29:48 UTC 
The attached patch fixes an issue where the screen turns white instead of black when the lock dialog is cancelled by hitting escape, or waiting for the timeout.

See downstream bug report:

https://bugs.launchpad.net/ubuntu/+source/gnome-screensaver/+bug/826269

Thanks!
Comment 1 Marc Deslauriers 2011-08-25 17:30:36 UTC 
Created attachment 194724 [details] [review]
proposed patch
Comment 2 Matthias Clasen 2011-08-26 12:11:29 UTC 
The following fixes have been pushed:
7b6d069 Properly clear to black when cancelling unlock
ec66dba gs-window-x11: Properly set background to black
Comment 3 Matthias Clasen 2011-08-26 12:11:31 UTC 
Created attachment 194819 [details] [review]
Properly clear to black when cancelling unlock

Since GTK+ is now drawing in more cases, we need to override
the GTK+ background color, instead of just setting the GDK
window background.

Based on a patch by Marc Deslauriers,
Comment 4 Matthias Clasen 2011-08-26 12:11:34 UTC 
Created attachment 194820 [details] [review]
gs-window-x11: Properly set background to black

This fixes an issue where if the lock dialog is cancelled by hitting
the escape key, or times out, the screen turns white instead of black.