After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 657347 - Retrieve the number of texture image units
Retrieve the number of texture image units
Status: RESOLVED FIXED
Product: cogl
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Cogl maintainer(s)
Cogl maintainer(s)
Depends on:
Blocks: 657225
 
 
Reported: 2011-08-25 16:48 UTC by Damien Lespiau
Modified: 2011-09-05 19:53 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
pipeline: Remove unsused get_max_texture_image_units() (2.41 KB, patch)
2011-08-25 16:48 UTC, Damien Lespiau
none Details | Review
context: Add an accessor to get display associated with the context (1.91 KB, patch)
2011-08-25 16:48 UTC, Damien Lespiau
none Details | Review
display: Add an accessor to get the renderer out of a display (2.00 KB, patch)
2011-08-25 16:49 UTC, Damien Lespiau
none Details | Review
renderer: Add cogl_renderer_get_n_fragment_texture_units() (2.84 KB, patch)
2011-08-25 16:49 UTC, Damien Lespiau
none Details | Review

Description Damien Lespiau 2011-08-25 16:48:53 UTC
It's always interesting to know how many samplers you can use in your shaders
and Cogl should expose that information. Let's start with how many samples
you can use in your fragment programs.
Comment 1 Damien Lespiau 2011-08-25 16:48:55 UTC
Created attachment 194718 [details] [review]
pipeline: Remove unsused get_max_texture_image_units()

This function was not used in the opengl pipeline, probably because of
the more precise get_max_activable_texture_units().

Remove it then.
Comment 2 Damien Lespiau 2011-08-25 16:48:57 UTC
Created attachment 194719 [details] [review]
context: Add an accessor to get display associated with the context
Comment 3 Damien Lespiau 2011-08-25 16:49:00 UTC
Created attachment 194720 [details] [review]
display: Add an accessor to get the renderer out of a display
Comment 4 Damien Lespiau 2011-08-25 16:49:02 UTC
Created attachment 194721 [details] [review]
renderer: Add cogl_renderer_get_n_fragment_texture_units()

Add a method on the renderer to know how many texture image units are
accessible from fragment shaders.
Comment 5 Robert Bragg 2011-09-05 19:53:39 UTC
thanks, these patches all looked good to me and they have all landed in master now and are available in the latest cogl-1.7.8 snapshot