After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 657151 - ogg: another cleanup round
ogg: another cleanup round
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
unspecified
Other All
: Normal normal
: 0.10.36
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-08-23 10:39 UTC by Vincent Penquerc'h
Modified: 2011-08-24 06:34 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
oggstream: set skeleton stream media type to application/x-ogg-skeleton (908 bytes, patch)
2011-08-23 10:39 UTC, Vincent Penquerc'h
committed Details | Review
oggstream: include stream type in warnings (2.31 KB, patch)
2011-08-23 10:39 UTC, Vincent Penquerc'h
committed Details | Review
oggdemux: do not try to determine duration of header packets (1.32 KB, patch)
2011-08-23 10:39 UTC, Vincent Penquerc'h
committed Details | Review
oggdemux: rename local variable for clarity (3.56 KB, patch)
2011-08-23 10:39 UTC, Vincent Penquerc'h
committed Details | Review
oggdemux: do not warn when finding a non BOS page (1.26 KB, patch)
2011-08-23 10:39 UTC, Vincent Penquerc'h
committed Details | Review
oggdemux: do not warn about expected occurences (1.01 KB, patch)
2011-08-23 10:39 UTC, Vincent Penquerc'h
committed Details | Review
oggstream: correctly identify skeleton EOS packet (1.20 KB, patch)
2011-08-23 10:39 UTC, Vincent Penquerc'h
committed Details | Review
oggdemux: add media type to chain information reports (1.08 KB, patch)
2011-08-23 10:39 UTC, Vincent Penquerc'h
committed Details | Review
oggdemux: do not warn when reaching EOS while scanning for the end chain (1.16 KB, patch)
2011-08-23 10:39 UTC, Vincent Penquerc'h
committed Details | Review

Description Vincent Penquerc'h 2011-08-23 10:39:29 UTC
Various cleanups and minor fixes, mostly to get rid of spurious
warnings about what we are actually expecting.
Comment 1 Vincent Penquerc'h 2011-08-23 10:39:31 UTC
Created attachment 194462 [details] [review]
oggstream: set skeleton stream media type to application/x-ogg-skeleton

This is to match the typefinder, and to make logs clearer.
Comment 2 Vincent Penquerc'h 2011-08-23 10:39:34 UTC
Created attachment 194463 [details] [review]
oggstream: include stream type in warnings

It makes it easier to work out what's going on.
Comment 3 Vincent Penquerc'h 2011-08-23 10:39:37 UTC
Created attachment 194464 [details] [review]
oggdemux: do not try to determine duration of header packets

Headers are inherently durationless.
Instead, set duration to 0 to avoid increasing tracked granpos,
and do not warn about it, since it is totally expected.
Comment 4 Vincent Penquerc'h 2011-08-23 10:39:40 UTC
Created attachment 194465 [details] [review]
oggdemux: rename local variable for clarity

While the casual reader might end up bewildered by just why this
change might increase clarity, it just happens than, in the libogg
and associated sources, op is the canonical name for an ogg_packet
whlie og is the canonical name for an ogg_page, and reading this
code confuses me.
Comment 5 Vincent Penquerc'h 2011-08-23 10:39:43 UTC
Created attachment 194466 [details] [review]
oggdemux: do not warn when finding a non BOS page

After all, we do hope to find actual data for these streams.
However, warn if we could not set up a chain when we find a
non BOS page, as that means we don't have a valid Ogg stream.
Comment 6 Vincent Penquerc'h 2011-08-23 10:39:46 UTC
Created attachment 194467 [details] [review]
oggdemux: do not warn about expected occurences

In this case, finding a skeleton packet.
Once upon a time, it used to be rare indeed, but no more.
Comment 7 Vincent Penquerc'h 2011-08-23 10:39:49 UTC
Created attachment 194468 [details] [review]
oggstream: correctly identify skeleton EOS packet

It is 0 byte, and was triggering the "bad packet" logic.
Comment 8 Vincent Penquerc'h 2011-08-23 10:39:52 UTC
Created attachment 194469 [details] [review]
oggdemux: add media type to chain information reports

One more little step in making logs a little less abstruse.
Comment 9 Vincent Penquerc'h 2011-08-23 10:39:56 UTC
Created attachment 194470 [details] [review]
oggdemux: do not warn when reaching EOS while scanning for the end chain

After all, we were asking for it.

This gets rid of the last warning-about-expected-condition.

w00t.
Comment 10 Sebastian Dröge (slomo) 2011-08-24 06:34:32 UTC
commit 7b8b0fa1bbc22bb08e291c001e4413b47d0b120e
Author: Vincent Penquerc'h <vincent.penquerch@collabora.co.uk>
Date:   Tue Aug 23 11:12:10 2011 +0100

    oggdemux: do not warn when reaching EOS while scanning for the end chain
    
    After all, we were asking for it.
    
    This gets rid of the last warning-about-expected-condition.
    
    w00t.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=657151

commit df40ddf0aab02d9269974ddb86879abeb0429aee
Author: Vincent Penquerc'h <vincent.penquerch@collabora.co.uk>
Date:   Tue Aug 23 11:08:25 2011 +0100

    oggdemux: add media type to chain information reports
    
    One more little step in making logs a little less abstruse.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=657151

commit 1e606c0456b8adcb2618f55c36a984a749afeb85
Author: Vincent Penquerc'h <vincent.penquerch@collabora.co.uk>
Date:   Tue Aug 23 11:05:11 2011 +0100

    oggstream: correctly identify skeleton EOS packet
    
    It is 0 byte, and was triggering the "bad packet" logic.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=657151

commit 68ed992e7e23a2a1d9494977f845cf1a7897b1f4
Author: Vincent Penquerc'h <vincent.penquerch@collabora.co.uk>
Date:   Tue Aug 23 10:58:20 2011 +0100

    oggdemux: do not warn about expected occurences
    
    In this case, finding a skeleton packet.
    Once upon a time, it used to be rare indeed, but no more.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=657151

commit 4fdb52871c87d419429ce697ed80387855daf64b
Author: Vincent Penquerc'h <vincent.penquerch@collabora.co.uk>
Date:   Tue Aug 23 10:47:53 2011 +0100

    oggdemux: do not warn when finding a non BOS page
    
    After all, we do hope to find actual data for these streams.
    However, warn if we could not set up a chain when we find a
    non BOS page, as that means we don't have a valid Ogg stream.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=657151

commit 564eedd2143e5f7739fc17ac6f03b76fcf9ca90e
Author: Vincent Penquerc'h <vincent.penquerch@collabora.co.uk>
Date:   Tue Aug 23 10:40:12 2011 +0100

    oggdemux: rename local variable for clarity
    
    While the casual reader might end up bewildered by just why this
    change might increase clarity, it just happens than, in the libogg
    and associated sources, op is the canonical name for an ogg_packet
    whlie og is the canonical name for an ogg_page, and reading this
    code confuses me.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=657151

commit 5d18496a5b0eaede10fb2d687e4bab7e879dddcc
Author: Vincent Penquerc'h <vincent.penquerch@collabora.co.uk>
Date:   Tue Aug 23 10:32:36 2011 +0100

    oggdemux: do not try to determine duration of header packets
    
    Headers are inherently durationless.
    Instead, set duration to 0 to avoid increasing tracked granpos,
    and do not warn about it, since it is totally expected.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=657151

commit 67a882afe7dbda862ec716230b0d690b3756fa5c
Author: Vincent Penquerc'h <vincent.penquerch@collabora.co.uk>
Date:   Tue Aug 23 10:29:49 2011 +0100

    oggstream: include stream type in warnings
    
    It makes it easier to work out what's going on.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=657151

commit 43cb76b1d8afcec7041c90a7899d07b134f2343b
Author: Vincent Penquerc'h <vincent.penquerch@collabora.co.uk>
Date:   Tue Aug 23 10:28:33 2011 +0100

    oggstream: set skeleton stream media type to application/x-ogg-skeleton
    
    This is to match the typefinder, and to make logs clearer.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=657151