After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 657091 - kate: do not clear out high bits from display area
kate: do not clear out high bits from display area
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
unspecified
Other All
: Normal normal
: 0.10.23
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-08-22 16:16 UTC by Vincent Penquerc'h
Modified: 2011-08-23 08:17 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
kate: do not clear out high bits from display area (1.68 KB, patch)
2011-08-22 16:16 UTC, Vincent Penquerc'h
committed Details | Review
kate: do not consider an empty SPU to be a fatal error (1.35 KB, patch)
2011-08-22 16:16 UTC, Vincent Penquerc'h
committed Details | Review

Description Vincent Penquerc'h 2011-08-22 16:16:24 UTC
http://dvd.sourceforge.net/spu_notes does not mention that high bits
are to be masked, and not clearing them makes a sample work, where
clearing them yielded left > right.
History from the dvdspu plugin, from where this code was copied,
does not shed any light, as tracing this code's origin shows
the same bitmasks being there in 2007 when it was imported.
Comment 1 Vincent Penquerc'h 2011-08-22 16:16:27 UTC
Created attachment 194385 [details] [review]
kate: do not clear out high bits from display area
Comment 2 Vincent Penquerc'h 2011-08-22 16:16:46 UTC
Created attachment 194386 [details] [review]
kate: do not consider an empty SPU to be a fatal error

Instead, just encode nothing and go on.
Comment 3 Sebastian Dröge (slomo) 2011-08-23 08:17:10 UTC
commit 1ed91ad1dba385b4d0d74d9713cb6bce7edc7cf9
Author: Vincent Penquerc'h <vincent.penquerch@collabora.co.uk>
Date:   Mon Aug 22 17:10:24 2011 +0100

    kate: do not consider an empty SPU to be a fatal error
    
    Instead, just encode nothing and go on.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=657091

commit 46cfb5fa4f6348135dc877be2e95ac15bd55d0c2
Author: Vincent Penquerc'h <vincent.penquerch@collabora.co.uk>
Date:   Mon Aug 22 17:15:10 2011 +0100

    kate: do not clear out high bits from display area
    
    http://dvd.sourceforge.net/spu_notes does not mention that high bits
    are to be masked, and not clearing them makes a sample work, where
    clearing them yielded left > right.
    History from the dvdspu plugin, from where this code was copied,
    does not shed any light, as tracing this code's origin shows
    the same bitmasks being there in 2007 when it was imported.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=657091