GNOME Bugzilla – Bug 657091
kate: do not clear out high bits from display area
Last modified: 2011-08-23 08:17:33 UTC
http://dvd.sourceforge.net/spu_notes does not mention that high bits are to be masked, and not clearing them makes a sample work, where clearing them yielded left > right. History from the dvdspu plugin, from where this code was copied, does not shed any light, as tracing this code's origin shows the same bitmasks being there in 2007 when it was imported.
Created attachment 194385 [details] [review] kate: do not clear out high bits from display area
Created attachment 194386 [details] [review] kate: do not consider an empty SPU to be a fatal error Instead, just encode nothing and go on.
commit 1ed91ad1dba385b4d0d74d9713cb6bce7edc7cf9 Author: Vincent Penquerc'h <vincent.penquerch@collabora.co.uk> Date: Mon Aug 22 17:10:24 2011 +0100 kate: do not consider an empty SPU to be a fatal error Instead, just encode nothing and go on. https://bugzilla.gnome.org/show_bug.cgi?id=657091 commit 46cfb5fa4f6348135dc877be2e95ac15bd55d0c2 Author: Vincent Penquerc'h <vincent.penquerch@collabora.co.uk> Date: Mon Aug 22 17:15:10 2011 +0100 kate: do not clear out high bits from display area http://dvd.sourceforge.net/spu_notes does not mention that high bits are to be masked, and not clearing them makes a sample work, where clearing them yielded left > right. History from the dvdspu plugin, from where this code was copied, does not shed any light, as tracing this code's origin shows the same bitmasks being there in 2007 when it was imported. https://bugzilla.gnome.org/show_bug.cgi?id=657091