After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 657067 - Can't build EDS backend using Vala master
Can't build EDS backend using Vala master
Status: RESOLVED FIXED
Product: folks
Classification: Platform
Component: e-d-s backend
git master
Other Linux
: Normal normal
: Unset
Assigned To: Raul Gutierrez Segales
Raul Gutierrez Segales
Depends on:
Blocks:
 
 
Reported: 2011-08-22 10:16 UTC by Guillaume Desmottes
Modified: 2011-08-22 12:55 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Guillaume Desmottes 2011-08-22 10:16:42 UTC
I got this when trying to build the EDS backend with Vala master:


  VALAC  libfolks_eds_la_vala.stamp
edsf-persona-store.vala:317.15-317.27: error: Argument 2: Cannot convert from `string?' to `GLib.Cancellable?'
              out added_uid);
              ^^^^^^^^^^^^^
edsf-persona-store.vala:366.17-367.47: error: 1 missing arguments for `bool E.BookClient.remove_contact (E.Contact contact, GLib.Cancellable? cancellable)'
edsf-persona-store.vala:546.19-546.38: error: Argument 2: Cannot convert from `string?' to `GLib.Cancellable?'
                  out supported_fields, null);
                  ^^^^^^^^^^^^^^^^^^^^
edsf-persona-store.vala:568.19-568.37: error: Argument 2: Cannot convert from `E.BookClientView' to `GLib.Cancellable?'
                  out this._ebookview);
                  ^^^^^^^^^^^^^^^^^^^
edsf-persona-store.vala:1017.17-1017.58: error: 1 missing arguments for `bool E.BookClient.modify_contact (E.Contact contact, GLib.Cancellable? cancellable)'
          yield this._addressbook.modify_contact (contact);
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
edsf-persona-store.vala:670.17-670.58: error: 1 missing arguments for `bool E.BookClient.modify_contact (E.Contact contact, GLib.Cancellable? cancellable)'
          yield this._addressbook.modify_contact (contact);
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
edsf-persona-store.vala:690.17-690.58: error: 1 missing arguments for `bool E.BookClient.modify_contact (E.Contact contact, GLib.Cancellable? cancellable)'
          yield this._addressbook.modify_contact (contact);
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
edsf-persona-store.vala:731.17-731.58: error: 1 missing arguments for `bool E.BookClient.modify_contact (E.Contact contact, GLib.Cancellable? cancellable)'
          yield this._addressbook.modify_contact (contact);
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
edsf-persona-store.vala:814.17-814.58: error: 1 missing arguments for `bool E.BookClient.modify_contact (E.Contact contact, GLib.Cancellable? cancellable)'
          yield this._addressbook.modify_contact (contact);
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
edsf-persona-store.vala:894.17-894.58: error: 1 missing arguments for `bool E.BookClient.modify_contact (E.Contact contact, GLib.Cancellable? cancellable)'
          yield this._addressbook.modify_contact (contact);
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
edsf-persona-store.vala:911.17-911.58: error: 1 missing arguments for `bool E.BookClient.modify_contact (E.Contact contact, GLib.Cancellable? cancellable)'
          yield this._addressbook.modify_contact (contact);
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
edsf-persona-store.vala:927.17-927.58: error: 1 missing arguments for `bool E.BookClient.modify_contact (E.Contact contact, GLib.Cancellable? cancellable)'
          yield this._addressbook.modify_contact (contact);
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
edsf-persona-store.vala:1000.17-1000.58: error: 1 missing arguments for `bool E.BookClient.modify_contact (E.Contact contact, GLib.Cancellable? cancellable)'
          yield this._addressbook.modify_contact (contact);
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
edsf-persona-store.vala:1032.17-1032.58: error: 1 missing arguments for `bool E.BookClient.modify_contact (E.Contact contact, GLib.Cancellable? cancellable)'
          yield this._addressbook.modify_contact (contact);
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
edsf-persona-store.vala:1067.17-1067.58: error: 1 missing arguments for `bool E.BookClient.modify_contact (E.Contact contact, GLib.Cancellable? cancellable)'
          yield this._addressbook.modify_contact (contact);
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
edsf-persona-store.vala:1102.17-1102.58: error: 1 missing arguments for `bool E.BookClient.modify_contact (E.Contact contact, GLib.Cancellable? cancellable)'
          yield this._addressbook.modify_contact (contact);
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
edsf-persona-store.vala:1164.17-1164.58: error: 1 missing arguments for `bool E.BookClient.modify_contact (E.Contact contact, GLib.Cancellable? cancellable)'
          yield this._addressbook.modify_contact (contact);
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
edsf-persona-store.vala:1196.17-1196.58: error: 1 missing arguments for `bool E.BookClient.modify_contact (E.Contact contact, GLib.Cancellable? cancellable)'
          yield this._addressbook.modify_contact (contact);
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Compilation failed: 18 error(s), 0 warning(s)
Comment 1 Raul Gutierrez Segales 2011-08-22 12:23:17 UTC
As per commit (in Vala):

commit 004b48261aaf77342c6cb489f04ab88e6d33366c
Author: Luca Bruno <lucabru@src.gnome.org>
Date:   Thu Aug 11 17:48:11 2011 +0200

    girparser: Do not reorder the cancellable parameter in async methods
    
    The feature was incomplete and flawed.

support for reordering Cancellables was dropped, so that broke our builds. I'll push an update.
Comment 2 Raul Gutierrez Segales 2011-08-22 12:55:35 UTC
Pushed:

commit c0ecad63015078231934e63ec63f02b97defb730
Author: Raul Gutierrez Segales <rgs@collabora.co.uk>
Date:   Mon Aug 22 13:51:28 2011 +0100

    e-d-s: Vala dropped support for reordering GCancellable params
    
    A couple of e-d-s methods (get_contact, modify_contact,
    get_backend_property, etc) experienced an automatic API
    change in it's Vala binding due to Vala dropping support
    for reordering GCancellable params.
    
    Fixes: https://bugzilla.gnome.org/show_bug.cgi?id=657067