GNOME Bugzilla – Bug 657065
Cache keeps around contacts from disabled accounts
Last modified: 2011-09-14 19:38:52 UTC
I am using Empathy with a new enough folks to have the persona cache. I enabled a test account and all the test contacts from that account appeared in my contact list. I disabled the account and all the contacts stayed around in my contact list. I don't think we should keep showing these contacts even when the account is disabled, so folks shouldn't expose these.
I agree.
Created attachment 194437 [details] [review] Add some more conditions for cache loads and unloads in Tpf.PersonaStore https://www.gitorious.org/folks/folks/commits/657065-cache-fixes Hopefully this will fix it. I couldn't actually reproduce the problem: I think because my HDD is slow, which changed the race condition between two calls to Tpf.PersonaStore._store_cache() and Tpf.PersonaStore._load_cache() which I think was causing the issue. Jonny, would you mind giving this folks branch a spin and seeing what happens?
Didn't make this release; punting to 0.6.2.
(Punting bugs to 0.6.4)
Anybody fancy some reviewing?
Comment on attachment 194437 [details] [review] Add some more conditions for cache loads and unloads in Tpf.PersonaStore Sorry for the delay - patch looks good. I wasn't able to reproduce this though.
Comment on attachment 194437 [details] [review] Add some more conditions for cache loads and unloads in Tpf.PersonaStore Committed with an addition to NEWS. commit 419fbf6a4c4a4701f1520bac2ccc9269dded015b Author: Philip Withnall <philip@tecnocode.co.uk> Date: Mon Aug 22 23:54:08 2011 +0100 Bug 657065 — Cache keeps around contacts from disabled accounts Add some extra conditions on loading and storing the Tpf.PersonaStore cache, so as to prevent loading it when the account is disabled or invalid, and to prevent storing it unnecessarily. This also adds some extra debug output to Tpf.PersonaStore's caching methods. Closes: bgo#657065 NEWS | 1 + backends/telepathy/lib/tpf-persona-store.vala | 64 +++++++++++++++++------- 2 files changed, 46 insertions(+), 19 deletions(-)