After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 657029 - Fails to build in jhbuild with vala master
Fails to build in jhbuild with vala master
Status: RESOLVED FIXED
Product: cheese
Classification: Applications
Component: general
git master
Other Linux
: Normal blocker
: 3.0
Assigned To: Cheese Maintainer(s)
Cheese Maintainer(s)
: 657070 657116 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2011-08-21 19:34 UTC by Kjartan Maraas
Modified: 2011-09-08 16:13 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
fix the build failure (3.04 KB, patch)
2011-09-07 21:00 UTC, David King
committed Details | Review

Description Kjartan Maraas 2011-08-21 19:34:08 UTC
make[2]: Entering directory `/home/kmaraas/src/gnome/cheese/src'
/opt/gnome2/bin/valac  --thread --vapidir vapi --pkg config --pkg gtk+-3.0 --pkg gmodule-2.0 --pkg gee-1.0 --pkg clutter-1.0 --pkg clutter-gtk-1.0 --pkg gstreamer-0.10 --pkg libcanberra-gtk --pkg libcanberra --pkg eogthumbnav --pkg cheese-thumbview --pkg cheese-common --pkg clutter-tablelayout -C cheese-main.vala cheese-window.vala cheese-countdown.vala cheese-effects-manager.vala cheese-preferences.vala thumbview/cheese-thumb-view.c thumbview/cheese-thumbnail.c thumbview/eog-thumb-nav.c
clutter-tablelayout.vapi:15.3-15.50: error: `Clutter' already contains a definition for `TableLayout'
  public class TableLayout : Clutter.LayoutManager {
  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
clutter-1.0.vapi:1477.2-1477.49: note: previous definition of `TableLayout' was here
	public class TableLayout : Clutter.LayoutManager {
	^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
clutter-tablelayout.vapi:8.3-8.28: error: `Clutter' already contains a definition for `TableAlignment'
  public enum TableAlignment {
  ^^^^^^^^^^^^^^^^^^^^^^^^^^
clutter-1.0.vapi:2355.2-2355.27: note: previous definition of `TableAlignment' was here
	public enum TableAlignment {
	^^^^^^^^^^^^^^^^^^^^^^^^^^
Compilation failed: 2 error(s), 0 warning(s)
make[2]: *** [cheese_vala.stamp] Error 1
make[2]: Leaving directory `/home/kmaraas/src/gnome/cheese/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/kmaraas/src/gnome/cheese'
make: *** [all] Error 2
Comment 1 André Klapper 2011-09-02 13:57:37 UTC
*** Bug 657070 has been marked as a duplicate of this bug. ***
Comment 2 André Klapper 2011-09-02 13:59:32 UTC
*** Bug 657116 has been marked as a duplicate of this bug. ***
Comment 3 David King 2011-09-07 21:00:36 UTC
Created attachment 195934 [details] [review]
fix the build failure

The attached patch fixes the build failure for me, with the latest Vala.
Comment 4 André Klapper 2011-09-08 07:49:51 UTC
Dave's patch fixes the cheese build for me.
Comment 5 David King 2011-09-08 08:02:13 UTC
I have pushed this and several other patches to the ‘cheese-next’ branch:

http://git.gnome.org/browse/cheese/log/?h=cheese-next

I will request a merge with master before 3.1.92, as there are some important (and some not so important) fixes there, most of which are also applicable to the gnome-3-0 branch.
Comment 6 David King 2011-09-08 16:13:39 UTC
Comment on attachment 195934 [details] [review]
fix the build failure

Pushed to master as commit cbf35868090eebd96e6210c32186f623bd68ae1e.