GNOME Bugzilla – Bug 656977
If icons aren't shown on the Desktop, disable the options to show specific icons
Last modified: 2013-07-17 21:25:28 UTC
If "Have file manager handle the desktop" is off, then the other options on the Desktop (File Manager) panel won't have any visible effect if they are changed. They should therefore be disabled as long as that setting is off, to make it clear to users that the first settings affects all of the other desktop icon settings.
So, Do we need to make the enabled icons like Trash, Computer, etc. visible on the scrren if they are enabled and the "Have file manager handle the desktop" is off ??? OR User will not be allowed to enable the other option, if "Have file manager handle the desktop" is off ??
I think all the other 'Show...on desktop' options should be disabled if the file manager switch is off
(thanks Mattias, I agree. This is my "explain how you might fix this bug and why" test for GSOC students)
I have fixed this bug, but need reviwing. The Pull Request's link: https://github.com/nzjrs/gnome-tweak-tool/pull/2 It does the following rask: -> When "Have file manager handle the desktop" is off from start, then all the other options will also be OFF by default. -> If this option is on, then the other options will behave normally, but when in between this option is OFF, then all the other options are disabled (ie. are set to OFF)
Created attachment 241861 [details] [review] Also made a Pull Request for the same patch, Please Review it.
Created attachment 242160 [details] [review] Patch to make the dependent options insensitive when show-desktop-icons is off. I think you need to retain the status of the dependent options (on/off) and make them insensitive when show-desktop-icons is off, instead of turning them all off. Also, I find it more appropriate to make this change inside the tweak_nautilus.py file. I've attached a patch with my approach.
*** Bug 700026 has been marked as a duplicate of this bug. ***
Created attachment 249447 [details] [review] desktop options are only sensitive if filemanager manages the desktop
Comment on attachment 249447 [details] [review] desktop options are only sensitive if filemanager manages the desktop Attachment 249447 [details] pushed as a46bbdb - desktop options are only sensitive if filemanager manages the desktop
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.