After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 656971 - Deprecate GDataDocumentsDocument subclasses
Deprecate GDataDocumentsDocument subclasses
Status: RESOLVED FIXED
Product: libgdata
Classification: Platform
Component: Google Documents service
git master
Other All
: Normal normal
: 0.12
Assigned To: libgdata-maint
libgdata-maint
Depends on: 593537 607616
Blocks:
 
 
Reported: 2011-08-20 18:45 UTC by Philip Withnall
Modified: 2012-04-14 09:31 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Philip Withnall 2011-08-20 18:45:17 UTC
They make things unnecessarily awkward without adding anything useful, since we can now upload documents of any type.
Comment 1 Philip Withnall 2011-08-20 18:49:19 UTC
Relatedly, the export_format stuff needs tidying up.
Comment 2 Philip Withnall 2011-10-11 08:05:09 UTC
(In reply to comment #0)
> …since we can now upload documents of any type.

…but only if we're using version 3.0 of the API, apparently.
Comment 3 Philip Withnall 2012-04-13 15:15:40 UTC
Not fixed yet, but this commit goes most of the way.

commit 1d0e74eeb0851d5be40b5d79d153682d52712180
Author: Philip Withnall <philip@tecnocode.co.uk>
Date:   Fri Apr 13 13:20:00 2012 +0100

    documents: Make GDataDocumentsDocument non-abstract
    
    It now represents arbitrary files, so that Google Documents can be used as
    a kind of remote filesystem.
    
    This shouldn’t be an API break.
    
    Helps: https://bugzilla.gnome.org/show_bug.cgi?id=656971

 docs/reference/gdata-sections.txt                  |    1 +
 gdata/gdata.symbols                                |    1 +
 .../services/documents/gdata-documents-document.c  |   34 +++++++++++++++++--
 .../services/documents/gdata-documents-document.h  |    2 +
 4 files changed, 34 insertions(+), 4 deletions(-)
Comment 4 Philip Withnall 2012-04-14 09:31:51 UTC
There’s not actually anything else to do here. We can’t deprecate the GDataDocumentsDocument subclasses since they have different kind URIs to GDataDocumentsDocument. Changing the way this works would require a fairly substantial reworking of how libgdata treats kinds, which I think is unnecessary.

I’ve added a single missing export format, but apart from that I can’t see how to tidy up export formats.

commit 8f084ed2f1d8f3256c12ad7184639d0dd2c68ccd
Author: Philip Withnall <philip@tecnocode.co.uk>
Date:   Sat Apr 14 09:52:40 2012 +0100

    documents: Add GDATA_DOCUMENTS_TEXT_JPEG export format
    
    API additions:
     • GDATA_DOCUMENTS_TEXT_JPEG

 docs/reference/gdata-sections.txt               |    1 +
 gdata/services/documents/gdata-documents-text.h |   13 +++++++++++++
 2 files changed, 14 insertions(+), 0 deletions(-)