After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 656967 - aisleriot-3.1.1 fails to build due to undeclared AR_RUNTIME_GAME_HELP_DIRECTORY
aisleriot-3.1.1 fails to build due to undeclared AR_RUNTIME_GAME_HELP_DIRECTORY
Status: RESOLVED FIXED
Product: aisleriot
Classification: Other
Component: general
3.1.x
Other Linux
: Normal normal
: ---
Assigned To: aisleriot-maint
aisleriot-maint
Depends on:
Blocks:
 
 
Reported: 2011-08-20 17:49 UTC by Alexandre Rostovtsev
Modified: 2011-08-22 03:21 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
trivial patch to use AR_RUNTIME_HELP_DIRECTORY in ar-help.c (878 bytes, patch)
2011-08-20 17:50 UTC, Alexandre Rostovtsev 		none Details | Review

Description Alexandre Rostovtsev 2011-08-20 17:49:02 UTC 
aisletiot-3.1.1 fails to build because it uses the undeclared AR_RUNTIME_GAME_HELP_DIRECTORY in src/lib/ar-help.c:


  CC     libaisleriot_la-ar-help.lo
ar-help.c: In function ‘ar_help_display_full’:
ar-help.c:75:40: error: ‘AR_RUNTIME_GAME_HELP_DIRECTORY’ undeclared (first use in this function)
ar-help.c:75:40: note: each undeclared identifier is reported only once for each function it appears in
make[4]: *** [libaisleriot_la-ar-help.lo] Error 1


Presumably, it should be replaced with AR_RUNTIME_HELP_DIRECTORY (declared in ar-runtime.h).
Comment 1 Alexandre Rostovtsev 2011-08-20 17:50:45 UTC 
Created attachment 194303 [details] [review]
trivial patch to use AR_RUNTIME_HELP_DIRECTORY in ar-help.c
Comment 2 Christian Persch 2011-08-20 18:26:56 UTC 
Thanks! Please commit to master.
Comment 3 Alexandre Rostovtsev 2011-08-20 18:39:14 UTC 
(In reply to comment #2)
> Thanks! Please commit to master.

I can't, I don't have gnome commit rights.
Comment 4 Christian Persch 2011-08-21 16:38:26 UTC 
Fixed on master.

Just curious, is there any special reason you're building --with-help-method=file instead of the default (ghelp) ?
Comment 5 Alexandre Rostovtsev 2011-08-22 03:21:18 UTC 
(In reply to comment #4)
> Just curious, is there any special reason you're building
> --with-help-method=file instead of the default (ghelp) ?

I was experimenting with building an aisleriot package without gnome integration, and therefore tried --with-platform=gtk-only --with-help-method=file.