After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 656929 - vp8: drop frames is a uint in the libvpx API, not a boolean
vp8: drop frames is a uint in the libvpx API, not a boolean
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
unspecified
Other All
: Normal normal
: 0.10.23
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-08-19 18:23 UTC by Vincent Penquerc'h
Modified: 2011-09-02 00:14 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
vp8: drop frames is a uint in the libvpx API, not a boolean (2.14 KB, patch)
2011-08-19 18:23 UTC, Vincent Penquerc'h 		none Details | Review

Description Vincent Penquerc'h 2011-08-19 18:23:52 UTC 
Looking in the libvpx history seems to have had it as a uint since
the start, so I'm not sure why it's a boolean here.
Comment 1 Vincent Penquerc'h 2011-08-19 18:23:54 UTC 
Created attachment 194257 [details] [review]
vp8: drop frames is a uint in the libvpx API, not a boolean
Comment 2 David Schleef 2011-08-22 03:17:52 UTC 
Properties shouldn't be uint unless there's a specific need for them, in which case the property should probably be uint32.  But obviously, boolean is very wrong.


commit 3ac9a366760da09a240bf35a4bad0dfd2ada9dd5
Author: David Schleef <ds@schleef.org>
Date:   Sun Aug 21 20:15:25 2011 -0700

    vp8enc: fix drop-frame property
    
    Fixes #656929.
Comment 3 David Schleef 2011-09-02 00:14:32 UTC 
I mean

commit cd35839e9868b86ba7988db1dd2aedc4c23af7ba