After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 656906 - Make 'make check' run unit tests in glib-networking
Make 'make check' run unit tests in glib-networking
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: network
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on: 656914
Blocks:
 
 
Reported: 2011-08-19 12:55 UTC by Stef Walter
Modified: 2011-08-26 13:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
tls: Make 'make check' work properly with tests (5.57 KB, patch)
2011-08-19 12:55 UTC, Stef Walter 		none Details | Review
tls: Clean up testing and coverage support (7.92 KB, patch)
2011-08-19 14:41 UTC, Stef Walter 		accepted-commit_now Details | Review
Updated with that change. Won't merge until bug #656914 is in. (7.84 KB, patch)
2011-08-26 06:12 UTC, Stef Walter 		none Details | Review

Description Stef Walter 2011-08-19 12:55:07 UTC 
Currently 'make check' doesn't run the unit tests in glib-networking.
Comment 1 Stef Walter 2011-08-19 12:55:27 UTC 
Created attachment 194230 [details] [review]
tls: Make 'make check' work properly with tests

Use a similar approach to glib to running gtester and hooking in the
unit tests to 'make check'
Comment 2 Stef Walter 2011-08-19 14:41:37 UTC 
Created attachment 194234 [details] [review]
tls: Clean up testing and coverage support

* Make 'make check' work properly with tests
 * Use a similar approach to glib to running gtester and hooking
   in the unit tests to 'make check'
 * Use GIO_EXTRA_MODULES to load the in-tree gnutls module.
 * Add coverage support similar to glib
Comment 3 Dan Winship 2011-08-26 00:16:04 UTC 
Comment on attachment 194234 [details] [review]
tls: Clean up testing and coverage support

blah. more fodder for Makefile.glib...

looks ok though

>+TEST_ENVIRONMENT =   \
>+	GIO_EXTRA_MODULES=$(top_builddir)/tls/gnutls/.libs \
>+	LD_LIBRARY_PATH=$(top_builddir)/tls/gnutls/.libs

you should not need to set LD_LIBRARY_PATH; that's what the libtool wrapper scripts are for
Comment 4 Stef Walter 2011-08-26 06:12:15 UTC 
Created attachment 194785 [details] [review]
Updated with that change. Won't merge until bug #656914 is in.
Comment 5 Stef Walter 2011-08-26 13:30:31 UTC 
Merged.