GNOME Bugzilla – Bug 656831
Rely on Empathy's factory to prepare TpConnection features
Last modified: 2011-08-19 07:30:19 UTC
Let's use these new API to remove code!
Created attachment 194144 [details] [review] ask factory to prepare TP_ACCOUNT_FEATURE_CONNECTION So we can rely on the connection returned by tp_account_get_connection() to be usable right away.
Created attachment 194145 [details] [review] account-chooser: rely on the factory to prepare TP_CONNECTION_FEATURE_CAPABILITIES, Also simplify empathy_account_chooser_filter_supports_chatrooms in the process.
Created attachment 194146 [details] [review] avatar-chooser: rely on the factory to prepare TP_CONNECTION_FEATURE_AVATAR_REQUIREMENTS
Created attachment 194147 [details] [review] contact-search-dialog: rely on the factory to prepare TP_CONNECTION_FEATURE_AVATAR_REQUIREMENTS
Created attachment 194148 [details] [review] contact-widget: rely on the factory to prepare TP_CONNECTION_FEATURE_CONTACT_INFO
Created attachment 194149 [details] [review] individual-widget: rely on the factory to prepare TP_CONNECTION_FEATURE_CONTACT_INFO
Created attachment 194150 [details] [review] new-call-dialog: rely on the factory to prepare TP_CONNECTION_FEATURE_CAPABILITIES
Created attachment 194151 [details] [review] ft-handler: rely on the factory to prepare TP_CONNECTION_FEATURE_CAPABILITIES
Created attachment 194152 [details] [review] new-message-dialog: rely on the factory to prepare TP_CONNECTION_FEATURE_CAPABILITIES
Created attachment 194153 [details] [review] tp-chat: rely on the factory to prepare TP_CONNECTION_FEATURE_CAPABILITIES
Created attachment 194154 [details] [review] rely on the factory to prepare TP_CONNECTION_FEATURE_CAPABILITIES
Also in http://cgit.collabora.com/git/user/cassidy/empathy/log/?h=conn-features-656831
Review of attachment 194154 [details] [review]: commit msg is wrong, it is about BALANCE not CAPABILITIES ::: src/empathy-main-window.c @@ +1077,3 @@ + /* need to prepare the connection: + * store the account on the connection */ + g_object_set_data (G_OBJECT (conn), "account", account); That should not be needed anymore with tp_connection_get_account(). But that's unrelated to this commit, but please open a bug or keep that in mind :)
+1 for all others, nice work !
(In reply to comment #13) > Review of attachment 194154 [details] [review]: > > commit msg is wrong, it is about BALANCE not CAPABILITIES Oops, fixed. > ::: src/empathy-main-window.c > @@ +1077,3 @@ > + /* need to prepare the connection: > + * store the account on the connection */ > + g_object_set_data (G_OBJECT (conn), "account", account); > > That should not be needed anymore with tp_connection_get_account(). But that's > unrelated to this commit, but please open a bug or keep that in mind :) That was on my mental TODO list, but yeah always better to open a bug: bug #656866
Attachment 194144 [details] pushed as 5f8f65f - ask factory to prepare TP_ACCOUNT_FEATURE_CONNECTION Attachment 194145 [details] pushed as 5a38618 - account-chooser: rely on the factory to prepare TP_CONNECTION_FEATURE_CAPABILITIES, Attachment 194146 [details] pushed as 7cbbd2e - avatar-chooser: rely on the factory to prepare TP_CONNECTION_FEATURE_AVATAR_REQUIREMENTS Attachment 194147 [details] pushed as 8b69b96 - contact-search-dialog: rely on the factory to prepare TP_CONNECTION_FEATURE_AVATAR_REQUIREMENTS Attachment 194148 [details] pushed as c428f8a - contact-widget: rely on the factory to prepare TP_CONNECTION_FEATURE_CONTACT_INFO Attachment 194149 [details] pushed as a87c731 - individual-widget: rely on the factory to prepare TP_CONNECTION_FEATURE_CONTACT_INFO Attachment 194150 [details] pushed as 3370401 - new-call-dialog: rely on the factory to prepare TP_CONNECTION_FEATURE_CAPABILITIES Attachment 194151 [details] pushed as 686b4e2 - ft-handler: rely on the factory to prepare TP_CONNECTION_FEATURE_CAPABILITIES Attachment 194152 [details] pushed as c9b5bba - new-message-dialog: rely on the factory to prepare TP_CONNECTION_FEATURE_CAPABILITIES Attachment 194153 [details] pushed as 3f96f6d - tp-chat: rely on the factory to prepare TP_CONNECTION_FEATURE_CAPABILITIES