After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 656797 - gnect: Several themes use the wrong player names
gnect: Several themes use the wrong player names
Status: RESOLVED FIXED
Product: gnome-games-superseded
Classification: Deprecated
Component: gnect
trunk
Other Linux
: Normal normal
: ---
Assigned To: Jason Clinton
GNOME Games maintainers
Depends on:
Blocks:
 
 
Reported: 2011-08-18 02:48 UTC by Jeremy Bicha
Modified: 2011-09-05 10:14 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
0001-gnect-Use-the-correct-player-names-in-Preferences.patch (1.12 KB, patch)
2011-08-18 02:50 UTC, Jeremy Bicha 		committed Details | Review

Description Jeremy Bicha 2011-08-18 02:48:02 UTC 
Colors listed for Player One and Player Two in Preferences aren't
correct for several themes.

As reported at https://bugs.launchpad.net/bugs/807574
Comment 1 Jeremy Bicha 2011-08-18 02:50:57 UTC 
Created attachment 194095 [details] [review]
0001-gnect-Use-the-correct-player-names-in-Preferences.patch
Comment 2 Thomas Andersen 2011-08-30 00:03:35 UTC 
Jason,

string freeze is in one week. Do you plan to land the patch or some other fix for this before then?

(patch looks good to me. Maybe circle/cross is easier for translators than O/X?)
Comment 3 Jeremy Bicha 2011-08-30 00:27:25 UTC 
I now have git commit privileges so I can apply this when approved. The original bug report said circle/cross. Is that what I should use?
Comment 4 Jeremy Bicha 2011-09-02 08:20:34 UTC 
Hi, just a friendly ping since Beta 2/String Freeze is coming up right after the weekend.
Comment 5 Thomas Andersen 2011-09-05 08:50:31 UTC 
I would say circle/cross. Feel free to commit with that change.