After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 656679 - [gi] Add two annotations to gio
[gi] Add two annotations to gio
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gio
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2011-08-16 17:12 UTC by Torsten Schoenfeld
Modified: 2011-10-15 22:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[gi] Add two annotations to gio (1.09 KB, patch)
2011-08-16 17:12 UTC, Torsten Schoenfeld 		reviewed Details | Review
[gi] Add two annotations to gio (1.09 KB, patch)
2011-08-17 19:14 UTC, Torsten Schoenfeld 		none Details | Review
[gi] Add two annotations to gio (1.09 KB, patch)
2011-08-17 19:18 UTC, Torsten Schoenfeld 		accepted-commit_now Details | Review
Add two annotations to gio (1.09 KB, patch)
2011-10-15 22:03 UTC, Matthias Clasen 		committed Details | Review

Description Torsten Schoenfeld 2011-08-16 17:12:55 UTC 
This patch adds two annotations, to g_file_hash and to
g_file_info_get_modification_time.
Comment 1 Torsten Schoenfeld 2011-08-16 17:12:57 UTC 
Created attachment 193979 [details] [review]
[gi] Add two annotations to gio
Comment 2 Matthias Clasen 2011-08-17 00:57:01 UTC 
Review of attachment 193979 [details] [review]:

::: gio/gfile.c
@@ +537,3 @@
 /**
  * g_file_hash:
+ * @file (type File): #gconstpointer to a #GFile.

Shouldn't that be type GFile ?
Comment 3 Matthias Clasen 2011-08-17 00:59:05 UTC 
Review of attachment 193979 [details] [review]:

::: gio/gfile.c
@@ +537,3 @@
 /**
  * g_file_hash:
+ * @file (type File): #gconstpointer to a #GFile.

Shouldn't that be type GFile ?
Comment 4 Torsten Schoenfeld 2011-08-17 19:14:03 UTC 
Created attachment 194073 [details] [review]
[gi] Add two annotations to gio
Comment 5 Torsten Schoenfeld 2011-08-17 19:14:46 UTC 
Comment on attachment 193979 [details] [review]
[gi] Add two annotations to gio

Ah, you're right.  Either 'GFile' or 'Gio.File', but not just 'File.
Comment 6 Torsten Schoenfeld 2011-08-17 19:18:14 UTC 
Created attachment 194074 [details] [review]
[gi] Add two annotations to gio

Colons were missing too.
Comment 7 Torsten Schoenfeld 2011-10-15 18:00:14 UTC 
Can attachment 194074 [details] [review] go in?  I verified that the changes have the desired effects in the generated .gir file.
Comment 8 Emmanuele Bassi (:ebassi) 2011-10-15 21:57:18 UTC 
Review of attachment 194074 [details] [review]:

looks good to me.
Comment 9 Matthias Clasen 2011-10-15 22:03:06 UTC 
The following fix has been pushed:
70eff50 Add two annotations to gio
Comment 10 Matthias Clasen 2011-10-15 22:03:08 UTC 
Created attachment 199081 [details] [review]
Add two annotations to gio