After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 656659 - Use vcards for postal addresses
Use vcards for postal addresses
Status: RESOLVED FIXED
Product: folks
Classification: Platform
Component: e-d-s backend
git master
Other Linux
: Normal normal
: Unset
Assigned To: Raul Gutierrez Segales
Raul Gutierrez Segales
Depends on:
Blocks:
 
 
Reported: 2011-08-16 14:53 UTC by Alexander Larsson
Modified: 2011-08-17 00:29 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Break out common code in edsf backend (3.07 KB, patch)
2011-08-16 14:54 UTC, Alexander Larsson
none Details | Review
Read postal addresses as vcards (3.58 KB, patch)
2011-08-16 14:54 UTC, Alexander Larsson
none Details | Review
Generalize Edsf.PersonaStore._set_contact_attributes (4.04 KB, patch)
2011-08-16 14:54 UTC, Alexander Larsson
none Details | Review
eds: Support writing postal addresses as vcards (2.79 KB, patch)
2011-08-16 14:54 UTC, Alexander Larsson
none Details | Review

Description Alexander Larsson 2011-08-16 14:53:02 UTC
To be useful for gnome-contacs we need to use the vcards stuff for the postal addresses. Attaching patches for this.
Comment 1 Alexander Larsson 2011-08-16 14:54:36 UTC
Created attachment 193958 [details] [review]
Break out common code in edsf backend

Most types use the same code to update the vcard params, so we
can share this code.
Comment 2 Alexander Larsson 2011-08-16 14:54:38 UTC
Created attachment 193959 [details] [review]
Read postal addresses as vcards
Comment 3 Alexander Larsson 2011-08-16 14:54:41 UTC
Created attachment 193960 [details] [review]
Generalize  Edsf.PersonaStore._set_contact_attributes

We need to handle non-string field details values when we implement
postal addresses.
Comment 4 Alexander Larsson 2011-08-16 14:54:44 UTC
Created attachment 193961 [details] [review]
eds: Support writing postal addresses as vcards
Comment 5 Raul Gutierrez Segales 2011-08-17 00:29:53 UTC
Merged:

commit 6b98480975464f9cadadd3841bc08ca38b69bd4f
Author: Alexander Larsson <alexl@redhat.com>
Date:   Tue Aug 16 16:53:14 2011 +0200

    eds: Support writing postal addresses as vcards
    
    https://bugzilla.gnome.org/show_bug.cgi?id=656659

commit 36c967607516279b606d6f2a88c0bb6942aa8a68
Author: Alexander Larsson <alexl@redhat.com>
Date:   Tue Aug 16 14:06:33 2011 +0200

    Generalize Edsf.PersonaStore._set_contact_attributes
    
    We need to handle non-string field details values when we implement
    postal addresses.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=656659

commit a58f2d813ebb38149c02352e3055ab7dba7d5611
Author: Alexander Larsson <alexl@redhat.com>
Date:   Tue Aug 16 14:06:10 2011 +0200

    Read postal addresses as vcards
    
    https://bugzilla.gnome.org/show_bug.cgi?id=656659

commit 7c2d5de039655b0db66f80a723a3c8d4be9d977d
Author: Alexander Larsson <alexl@redhat.com>
Date:   Tue Aug 16 14:04:44 2011 +0200

    Break out common code in edsf backend
    
    Most types use the same code to update the vcard params, so we
    can share this code.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=656659