After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 656649 - flacparse: fix off by one in frame size check
flacparse: fix off by one in frame size check
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
unspecified
Other All
: Normal normal
: 0.10.31
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-08-16 12:19 UTC by Vincent Penquerc'h
Modified: 2011-08-16 12:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
flacparse: fix off by one in frame size check (1015 bytes, patch)
2011-08-16 12:19 UTC, Vincent Penquerc'h 		committed Details | Review

Description Vincent Penquerc'h 2011-08-16 12:19:17 UTC 
Yes, I was tracking another bug and the small test file I generated
to test with improbably just happened to trigger this, with a second
and last frame of 1615 bytes.
Comment 1 Vincent Penquerc'h 2011-08-16 12:19:20 UTC 
Created attachment 193934 [details] [review]
flacparse: fix off by one in frame size check
Comment 2 Tim-Philipp Müller 2011-08-16 12:40:07 UTC 
Pushed, thanks :)
Comment 3 Tim-Philipp Müller 2011-08-16 12:40:23 UTC 
Comment on attachment 193934 [details] [review]
flacparse: fix off by one in frame size check

commit 6ac7ad8a2ce59bebcb5b5085fa48c354afff539f
Author: Vincent Penquerc'h <vincent.penquerch@collabora.co.uk>
Date:   Tue Aug 16 13:16:22 2011 +0100

    flacparse: fix off by one in frame size check
    
    Yes, I was tracking another bug and the small test file I generated
    to test with improbably just happened to trigger this, with a second
    and last frame of 1615 bytes.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=656649