GNOME Bugzilla – Bug 656619
Some modal dialog fixes
Last modified: 2011-08-29 17:28:59 UTC
These patches make the appearance and behavior of modal dialogs a bit better.
Created attachment 193906 [details] [review] Account for invisible borders when constraining modal dialogs
Created attachment 193907 [details] [review] Half invisible borders for modal dialogs
Created attachment 193908 [details] [review] Disable top resizing for attached modal dialogs
Review of attachment 193906 [details] [review]: Hmm, first fix seems right, other two changes I'm not so sure about ::: src/core/constraints.c @@ +769,1 @@ + y += info->borders->visible.top + info->borders->invisible.top; This seems wrong, we want to place the top of the visible frame at the bottom of the parent dialog, right, not the top of the invisible frame? ::: src/core/place.c @@ +793,3 @@ /* put top of child's frame, not top of child's client */ if (borders) + y += borders->visible.top + borders->invisible.top; This seems wrong - we want to place the top of the visible frame, not the top of the invisible frame.
Review of attachment 193908 [details] [review]: Seems sensible
Review of attachment 193907 [details] [review]: Was this a designer request? What's the rationale? (Commit message should mention the meta_theme_draw_frame_by_name() deletion as unused and why it was done as part of this patch)
Created attachment 195091 [details] [review] Account for invisible borders when constraining modal dialogs
Comment on attachment 193908 [details] [review] Disable top resizing for attached modal dialogs Attachment 193908 [details] pushed as e4da649 - Disable top resizing for attached modal dialogs
Review of attachment 195091 [details] [review]: Looks good
Review of attachment 193907 [details] [review]: <owen> [...] you wouldn't really notice unless you are trying to grab the border, and then having the bigger border is definitely good then <owen> magcius: I think I'm going to say let's just use the full width and avoid some artificial /2 in the code unless we have a request from the designers otherwise
Attachment 195091 [details] pushed as 05fee9b - Account for invisible borders when constraining modal dialogs