GNOME Bugzilla – Bug 656596
Outdated FSF Address in code files
Last modified: 2011-08-17 12:14:51 UTC
While building ghex on the Open Build Service (OBS), this minor warning is spit out at the end of the build: ghex-devel.x86_64: W: incorrect-fsf-address /usr/include/gtkhex-3/hex-document.h ghex-devel.x86_64: W: incorrect-fsf-address /usr/include/gtkhex-3/gtkhex.h ghex.x86_64: W: incorrect-fsf-address /usr/share/doc/packages/ghex/COPYING-DOCS ghex.x86_64: W: incorrect-fsf-address /usr/share/doc/packages/ghex/README ghex.x86_64: W: incorrect-fsf-address /usr/share/doc/packages/ghex/COPYING The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. Updating COPYING and the various headers with the current FSF provided ones should resolve the issues.
Thanks for pointing this out. Do you have a patch for fixing the addresses?
Will create one in the upcoming 12 hours if that helps.
Please do.
Created attachment 193918 [details] [review] Replace the FSF addresses in the header files I hope to have caught all of them without being too intrusive. I used 'licenscheck' to identify the files with the wrong addresses. COPYING and COPYING-DOCS have been fully copied from GPL: http://www.gnu.org/licenses/gpl-2.0.txt resp FDL: http://www.gnu.org/licenses/fdl-1.1.txt
Review of attachment 193918 [details] [review]: Thanks, pushed to master as 2e0d7f75. I found some very minor issues with the patch and and amended it before pushing: - git-am complained about 'new blank line at EOF.' for both of the COPYING files and sure enough, when compared to the downloaded FSF documents there was an extra newline in both files. - in the README file there was a trivial copy-paste error: + If not, write to the Free Software Foundation, Inc., 51 Franklin St, + Fifth Floor, Boston, MA 02110-1301 USA if not, write to the Free Software