After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 656576 - Video preview could have rounded corners
Video preview could have rounded corners
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: VoIP
unspecified
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
Depends on:
Blocks:
 
 
Reported: 2011-08-15 13:27 UTC by Jonny Lamb
Modified: 2011-08-19 09:54 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add a ClutterTexture subclass with rounded corners (5.77 KB, patch)
2011-08-17 16:01 UTC, Emilio Pozuelo Monfort
none Details | Review
CallWindow: round the video preview corners (1.10 KB, patch)
2011-08-17 16:01 UTC, Emilio Pozuelo Monfort
none Details | Review
CallWindow: make the info buttons rounded (1.70 KB, patch)
2011-08-17 16:02 UTC, Emilio Pozuelo Monfort
none Details | Review
Add a ClutterRectangle subclass with rounded corners (6.88 KB, patch)
2011-08-17 16:03 UTC, Emilio Pozuelo Monfort
none Details | Review
CallWindow: make the rectangles have rounded corners (1.09 KB, patch)
2011-08-17 16:03 UTC, Emilio Pozuelo Monfort
none Details | Review
Reimplement EmpathyRoundedRectangle using cairo (8.72 KB, patch)
2011-08-17 16:04 UTC, Emilio Pozuelo Monfort
none Details | Review
Make the preview corners more subtle (895 bytes, patch)
2011-08-17 16:04 UTC, Emilio Pozuelo Monfort
none Details | Review
Rounded preview (97.48 KB, image/png)
2011-08-17 16:20 UTC, Emilio Pozuelo Monfort
  Details
Add a ClutterTexture subclass with rounded corners (5.72 KB, patch)
2011-08-19 08:42 UTC, Emilio Pozuelo Monfort
accepted-commit_now Details | Review
CallWindow: round the video preview corners (1.10 KB, patch)
2011-08-19 08:42 UTC, Emilio Pozuelo Monfort
accepted-commit_now Details | Review
CallWindow: make the info buttons rounded (1.76 KB, patch)
2011-08-19 08:42 UTC, Emilio Pozuelo Monfort
accepted-commit_now Details | Review
Add a rectangle actor with rounded corners (7.95 KB, patch)
2011-08-19 08:42 UTC, Emilio Pozuelo Monfort
accepted-commit_now Details | Review
CallWindow: make the rectangles have rounded corners (2.80 KB, patch)
2011-08-19 08:42 UTC, Emilio Pozuelo Monfort
accepted-commit_now Details | Review
Make the preview corners more subtle (895 bytes, patch)
2011-08-19 08:42 UTC, Emilio Pozuelo Monfort
accepted-commit_now Details | Review

Description Jonny Lamb 2011-08-15 13:27:36 UTC
Now that we have EmpathyRoundedActor it should(?) be trivial to make the video preview (and perhaps even the remote video) have rounded corners?!! That'd be amaaaaazing if done tastefully!
Comment 1 Emilio Pozuelo Monfort 2011-08-17 16:01:35 UTC
Created attachment 194054 [details] [review]
Add a ClutterTexture subclass with rounded corners
Comment 2 Emilio Pozuelo Monfort 2011-08-17 16:01:55 UTC
Created attachment 194055 [details] [review]
CallWindow: round the video preview corners
Comment 3 Emilio Pozuelo Monfort 2011-08-17 16:02:25 UTC
Created attachment 194056 [details] [review]
CallWindow: make the info buttons rounded
Comment 4 Emilio Pozuelo Monfort 2011-08-17 16:03:09 UTC
Created attachment 194057 [details] [review]
Add a ClutterRectangle subclass with rounded corners
Comment 5 Emilio Pozuelo Monfort 2011-08-17 16:03:44 UTC
Created attachment 194058 [details] [review]
CallWindow: make the rectangles have rounded corners
Comment 6 Emilio Pozuelo Monfort 2011-08-17 16:04:21 UTC
Created attachment 194059 [details] [review]
Reimplement EmpathyRoundedRectangle using cairo

As Cairo is antialiased while Cogl is not.
Comment 7 Emilio Pozuelo Monfort 2011-08-17 16:04:50 UTC
Created attachment 194061 [details] [review]
Make the preview corners more subtle
Comment 8 Emilio Pozuelo Monfort 2011-08-17 16:20:02 UTC
Created attachment 194063 [details]
Rounded preview

The corners could be better but this is a good start. I'm not sure why they look thicker than the rest though...

We would need a UI freeze exception to get this in for 3.2.
Comment 9 Guillaume Desmottes 2011-08-18 16:27:26 UTC
Would it make sense to do some squashing before starting reviewing this?
Comment 10 Emilio Pozuelo Monfort 2011-08-18 17:21:33 UTC
I could squash "Reimplement EmpathyRoundedRectangle using cairo" if you want. The others make sense as they are.

Also I was wrong, UI freeze isn't in place yet!
Comment 11 Guillaume Desmottes 2011-08-19 07:24:24 UTC
(In reply to comment #10)
> I could squash "Reimplement EmpathyRoundedRectangle using cairo" if you want.

Yes please. There is no much sense to review an implementation which is going to be re-placed right away. :)
Comment 12 Emilio Pozuelo Monfort 2011-08-19 08:42:31 UTC
Created attachment 194193 [details] [review]
Add a ClutterTexture subclass with rounded corners
Comment 13 Emilio Pozuelo Monfort 2011-08-19 08:42:37 UTC
Created attachment 194194 [details] [review]
CallWindow: round the video preview corners
Comment 14 Emilio Pozuelo Monfort 2011-08-19 08:42:41 UTC
Created attachment 194195 [details] [review]
CallWindow: make the info buttons rounded
Comment 15 Emilio Pozuelo Monfort 2011-08-19 08:42:44 UTC
Created attachment 194196 [details] [review]
Add a rectangle actor with rounded corners

This is a ClutterCairoTexture subclass and uses Cairo for
drawing as Cairo is antialiased while Cogl is not.
Comment 16 Emilio Pozuelo Monfort 2011-08-19 08:42:48 UTC
Created attachment 194197 [details] [review]
CallWindow: make the rectangles have rounded corners
Comment 17 Emilio Pozuelo Monfort 2011-08-19 08:42:52 UTC
Created attachment 194198 [details] [review]
Make the preview corners more subtle
Comment 18 Guillaume Desmottes 2011-08-19 08:52:54 UTC
Review of attachment 194193 [details] [review]:

Looks like an interesting addition to Clutter. Please open a clutter bug suggesting to add something like that.
Comment 19 Guillaume Desmottes 2011-08-19 08:53:16 UTC
Review of attachment 194194 [details] [review]:

++
Comment 20 Guillaume Desmottes 2011-08-19 09:07:46 UTC
Review of attachment 194195 [details] [review]:

++
Comment 21 Guillaume Desmottes 2011-08-19 09:09:28 UTC
Review of attachment 194196 [details] [review]:

++
Comment 22 Guillaume Desmottes 2011-08-19 09:09:56 UTC
Review of attachment 194197 [details] [review]:

++
Comment 23 Guillaume Desmottes 2011-08-19 09:10:24 UTC
Review of attachment 194198 [details] [review]:

++ ; can be squashed
Comment 24 Emilio Pozuelo Monfort 2011-08-19 09:32:13 UTC
(In reply to comment #23)
> Review of attachment 194198 [details] [review]:
> 
> ++ ; can be squashed

Squashed.

Merged, thanks!
Comment 25 Emilio Pozuelo Monfort 2011-08-19 09:54:43 UTC
(In reply to comment #18)
> Review of attachment 194193 [details] [review]:
> 
> Looks like an interesting addition to Clutter. Please open a clutter bug
> suggesting to add something like that.

I've opened https://bugzilla.gnome.org/show_bug.cgi?id=656877 and https://bugzilla.gnome.org/show_bug.cgi?id=656879