GNOME Bugzilla – Bug 656576
Video preview could have rounded corners
Last modified: 2011-08-19 09:54:59 UTC
Now that we have EmpathyRoundedActor it should(?) be trivial to make the video preview (and perhaps even the remote video) have rounded corners?!! That'd be amaaaaazing if done tastefully!
Created attachment 194054 [details] [review] Add a ClutterTexture subclass with rounded corners
Created attachment 194055 [details] [review] CallWindow: round the video preview corners
Created attachment 194056 [details] [review] CallWindow: make the info buttons rounded
Created attachment 194057 [details] [review] Add a ClutterRectangle subclass with rounded corners
Created attachment 194058 [details] [review] CallWindow: make the rectangles have rounded corners
Created attachment 194059 [details] [review] Reimplement EmpathyRoundedRectangle using cairo As Cairo is antialiased while Cogl is not.
Created attachment 194061 [details] [review] Make the preview corners more subtle
Created attachment 194063 [details] Rounded preview The corners could be better but this is a good start. I'm not sure why they look thicker than the rest though... We would need a UI freeze exception to get this in for 3.2.
Would it make sense to do some squashing before starting reviewing this?
I could squash "Reimplement EmpathyRoundedRectangle using cairo" if you want. The others make sense as they are. Also I was wrong, UI freeze isn't in place yet!
(In reply to comment #10) > I could squash "Reimplement EmpathyRoundedRectangle using cairo" if you want. Yes please. There is no much sense to review an implementation which is going to be re-placed right away. :)
Created attachment 194193 [details] [review] Add a ClutterTexture subclass with rounded corners
Created attachment 194194 [details] [review] CallWindow: round the video preview corners
Created attachment 194195 [details] [review] CallWindow: make the info buttons rounded
Created attachment 194196 [details] [review] Add a rectangle actor with rounded corners This is a ClutterCairoTexture subclass and uses Cairo for drawing as Cairo is antialiased while Cogl is not.
Created attachment 194197 [details] [review] CallWindow: make the rectangles have rounded corners
Created attachment 194198 [details] [review] Make the preview corners more subtle
Review of attachment 194193 [details] [review]: Looks like an interesting addition to Clutter. Please open a clutter bug suggesting to add something like that.
Review of attachment 194194 [details] [review]: ++
Review of attachment 194195 [details] [review]: ++
Review of attachment 194196 [details] [review]: ++
Review of attachment 194197 [details] [review]: ++
Review of attachment 194198 [details] [review]: ++ ; can be squashed
(In reply to comment #23) > Review of attachment 194198 [details] [review]: > > ++ ; can be squashed Squashed. Merged, thanks!
(In reply to comment #18) > Review of attachment 194193 [details] [review]: > > Looks like an interesting addition to Clutter. Please open a clutter bug > suggesting to add something like that. I've opened https://bugzilla.gnome.org/show_bug.cgi?id=656877 and https://bugzilla.gnome.org/show_bug.cgi?id=656879