GNOME Bugzilla – Bug 656571
Call toolbar has some odd things
Last modified: 2018-05-22 14:58:48 UTC
Created attachment 193866 [details] screenshot Check out my awesome screenshot. That's me lolling. 1. The i button attached to the preview appears to be in the middle of nowhere and just looks really weird to me. 2. The rounded corners of the toolbar are really jagged. 3. The label on the right hand side of the toolbar is too close to the edge. 4. The preview is in a really weird place. Why is it nearly half-way up the window?
(In reply to comment #0) > Created an attachment (id=193866) [details] > screenshot > > Check out my awesome screenshot. That's me lolling. > > 1. The i button attached to the preview appears to be in the middle of nowhere > and just looks really weird to me. Indeed, I guess I forgot to update it's position when doing the move-preview stuff. I'll fix it. > 2. The rounded corners of the toolbar are really jagged. I'll see if I can make it smoother. > 3. The label on the right hand side of the toolbar is too close to the edge. We can add some padding there. > 4. The preview is in a really weird place. Why is it nearly half-way up the > window? Because if we don't do that and you make the window smaller, the preview will be on top of the toolbar (or viceversa).
Created attachment 193901 [details] [review] Display the preview video button in the preview corner
Created attachment 193902 [details] [review] Add some space between the status and the end of the toolbar
(In reply to comment #1) > (In reply to comment #0) > > 2. The rounded corners of the toolbar are really jagged. > > I'll see if I can make it smoother. This is done by cogl. The call is in empathy-rounded-actor.c: /* create and store a path describing a rounded rectangle */ cogl_path_round_rectangle (0, 0, width, height, height / 2, 0.1); Making arc_step (the last argument) smaller should make it less jagged, but setting it to 0.01 makes the window somewhat slow without any real differences. Not sure how to make this better.
Review of attachment 193902 [details] [review]: ++
Review of attachment 193901 [details] [review]: ++
Review of attachment 193901 [details] [review]: ::: src/empathy-call-window.c @@ +992,3 @@ + clutter_actor_set_size (box, + SELF_VIDEO_SECTION_WIDTH, + SELF_VIDEO_SECTION_HEIGTH + SELF_VIDEO_SECTION_MARGIN); HEIGHT not HEIGTH
Created attachment 193932 [details] [review] CallWindow: fix typo
Review of attachment 193932 [details] [review]: ++
Remaining here: 2. The rounded corners of the toolbar are really jagged.
(In reply to comment #10) > Remaining here: > > 2. The rounded corners of the toolbar are really jagged. I think the problem is that we do the clip with cogl, which is aliased.
We should paint the GtkWidget inside a ClutterCairoTexture and then do the cliping with cairo.
Actually doing that would probably be kinda complex as we would have to forward events ourselves (GtkClutterActor does that for us)
This will be easy when bug #659944 is fixed.
The way to fix this when that bug's fixed is to clip the corners of the image surface using Cairo, see cairo_clip()
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/empathy/issues/410.