GNOME Bugzilla – Bug 656547
implement loading of effects in libcheese
Last modified: 2011-08-21 09:50:13 UTC
We need to load effects in Empathy which is written in C. Other applications that want to use CheeseEffect will probably need this functionality too. Currently this is implemented in Cheese in Vala. We should make a helper function in libcheese to load effects and use the helper in Cheese from Vala and in Empathy from C.
Created attachment 193844 [details] [review] cheese-effects: implement loading cheese effects in libcheese
Review of attachment 193844 [details] [review]: Thanks for the patch. I think adding the loading of effects in libcheese is indeed a great thing.
Committed to master and gnome-3-0
Should I bump the version of cheese to 3.0.3 in the mean time before the release so that I can set a dependency in Empathy? Should I also update data/cheese.pc and data/cheese-gtk.pc and bump Version from 3.0.0 to 3.0.3? Also shouldn't these file's versions be set from the version in configure.ac?
Sorry, nevermind the .pc files. I now see we have .pc.in file to create them dynamically. Question remains: should we bump cheese version to 3.0.3?
In fact, this patch should not be pushed to branch gnome-3-0, which is where a release 3.0.3 would come from. Branch gnome-3-0 is freezed for feature and api change among others. Please revert the patch on it. We can make an unstable release for master branch if you want, so that empathy can depend on it. To follow gnome schedule I think the version number would be 3.1.5 or 3.1.90 if we are not going to add anything else for GNOME 3.2.
I reverted the patch on gnome-3-0. I'm sorry I pushed it there, but as I had to push all the previous patches to both master and gnome-3-0 I assumed this would go there too.
Created attachment 194322 [details] [review] configure.ac: bump cheese to 3.1.5 and libcheese version I'm attaching a patch to bump the version number. I also changed LT_VERSION for libcheese (but not for libcheese-gtk).