After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 656540 - Redundant call of mrp_interval_new() in sql_read_overriden_day_types()
Redundant call of mrp_interval_new() in sql_read_overriden_day_types()
Status: RESOLVED FIXED
Product: planner
Classification: Other
Component: General
0.14.x
Other Linux
: Normal normal
: ---
Assigned To: planner-maint
planner-maint
Depends on:
Blocks:
 
 
Reported: 2011-08-15 06:47 UTC by Maxim Zakharov
Modified: 2011-09-29 12:41 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
missed patch (770 bytes, patch)
2011-08-16 23:09 UTC, Maxim Zakharov
committed Details | Review

Description Maxim Zakharov 2011-08-15 06:47:36 UTC
The second call of mrp_interval_new() in sql_read_overriden_day_types() is truly redundant and likely lead to a memory leak.

The patch attached fixes the issue.
Comment 1 Alexandre Franke 2011-08-16 13:28:47 UTC
There's no patch attached.
Comment 2 Maxim Zakharov 2011-08-16 23:09:16 UTC
Created attachment 193995 [details] [review]
missed patch

Sorry. I attach missed patch.
I'm sure I'd attached this patch when posted the report.
Comment 3 Akhil Laddha 2011-09-29 10:12:40 UTC
Alexandre, would you please review the patch ?
Comment 4 Alexandre Franke 2011-09-29 12:41:23 UTC
This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.