After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 656517 - Do not add search path entry for non-existing directory.
Do not add search path entry for non-existing directory.
Status: RESOLVED FIXED
Product: seed
Classification: Bindings
Component: libseed
git master
Other All
: Normal normal
: ---
Assigned To: seed-maint
Depends on:
Blocks:
 
 
Reported: 2011-08-14 14:54 UTC by Alexandre Mazari
Modified: 2011-08-19 08:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Do not add search path entry for non-existing directory. (887 bytes, patch)
2011-08-14 14:55 UTC, Alexandre Mazari 		none Details | Review

Description Alexandre Mazari 2011-08-14 14:54:47 UTC 
This patch filter-out unexisting entries in the search path before trying to include extensions or native modules. This saves up some time and avoid uneeded looping.
Comment 1 Alexandre Mazari 2011-08-14 14:55:00 UTC 
Created attachment 193813 [details] [review]
Do not add search path entry for non-existing directory.
Comment 2 Alan Knowles 2011-08-15 02:51:52 UTC 
I think it might need to incorporate this test : 
!g_strcmp0(".",test_path))

As the last location to check is always the current script path (using '.')
Comment 3 Alexandre Mazari 2011-08-16 10:00:32 UTC 
Mmm... I suppose g_file_test will return TRUE with "." so do we need to special-case it, I guess.
Comment 4 Alan Knowles 2011-08-19 08:00:28 UTC 
Committed

Thanks
Alan