After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 656488 - imapx: Memory leak of mi->server_user_flags
imapx: Memory leak of mi->server_user_flags
Status: RESOLVED FIXED
Product: evolution-data-server
Classification: Platform
Component: Mailer
3.0.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: evolution-mail-maintainers
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2011-08-13 23:53 UTC by David Woodhouse
Modified: 2013-03-25 13:43 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
eds patch (2.03 KB, patch)
2013-03-20 08:36 UTC, Milan Crha
committed Details | Review

Description David Woodhouse 2011-08-13 23:53:09 UTC
==3576== 1,638 bytes in 53 blocks are definitely lost in loss record 24,058 of 25,597
==3576==    at 0x4A0649D: malloc (vg_replace_malloc.c:236)
==3576==    by 0x3D33049600: g_malloc (gmem.c:164)
==3576==    by 0x64A776D: camel_flag_set (camel-folder-summary.c:4128)
==3576==    by 0x64A7858: camel_flag_list_copy (camel-folder-summary.c:4211)
==3576==    by 0x1CDB31C2: imapx_update_user_flags (camel-imapx-utils.c:245)
==3576==    by 0x1CDB3904: imapx_update_message_info_flags (camel-imapx-utils.c:310)
==3576==    by 0x1CDC40F9: imapx_job_scan_changes_done (camel-imapx-server.c:3800)
==3576==    by 0x1CDC2FBB: imapx_step (camel-imapx-server.c:1955)
==3576==    by 0x1CDC3094: parse_contents (camel-imapx-server.c:4812)
==3576==    by 0x1CDC34CF: imapx_parser_thread (camel-imapx-server.c:4879)
==3576==    by 0x3D330683A5: g_thread_create_proxy (gthread.c:1955)
==3576==    by 0x3D31407B30: start_thread (pthread_create.c:305)

We don't seem to have an imapx_message_info_free() function in camel-imapx-summary.c that would free this field. It's not handled by imapx_message_info_clone() either.
Comment 1 Milan Crha 2013-03-20 08:36:09 UTC
Created attachment 239332 [details] [review]
eds patch

for evolution-data-server;

Right. This patch also fixes one more leak in imapx_untagged_bye().
Comment 2 Milan Crha 2013-03-25 13:43:14 UTC
Created commit 3c6202e in eds master (3.9.1+)
Created commit d3e1fe4 in eds gnome-3-8 (3.8.1+)