GNOME Bugzilla – Bug 656465
There are some missing files from POTFILES.in
Last modified: 2011-08-15 15:12:42 UTC
It seems there are some missing files in POTFILES.in, so D-L can't generate an updated POT file. Here is the error that D-L shows: There are some missing files from POTFILES.in: * data/ui/alignmentprogress.ui * data/ui/cliptransformation.ui * data/ui/depsmanager.ui * pitivi/formatters/etree.py Many thanks for your help
Created attachment 193775 [details] [review] Fixes error in POTFILES.in T
Created attachment 193778 [details] [review] translation: Add missing files to POTFILES.in Author is Daniel Mustieles
Comment on attachment 193778 [details] [review] translation: Add missing files to POTFILES.in Attachment 193778 [details] pushed as d087741 - translation: Add missing files to POTFILES.in
The patch still needs work. .ui files need to be prefixed by [type: gettext/glade] to be properly parsed by intltool. Isn't it possible to commit fixes directly in the GNOME Git repo of pitivi?
I fixed this in that commit: http://git.gnome.org/browse/pitivi/commit/?id=4486a59cebd4a997a2968313694b61144a5915d4 I hope you don't mind. I did it several times with other modules in the past few months.
Ok, I didn't know .ui file must be prefixed. i'll take it in account next time :). This bug is now fixed, so I'm closing it. Many thanks for your quick responses :)
Piotr, I would rather you don't push directly because we actually use git.pitivi.org as official repo. I had actually pushed the patch to the official repo, and got to do dirty merges to be able to get the 2 repos synced together again. Anyway thanks for your help and your responsivness :)
This out-of-GNOME git policy is clearly suboptimal and misleading, as it prevents GNOME hackers to directly contribute to Pitivi code. Of course, it's your choice, but you shouldn't be too much surprised to get commit in the GNOME repo.
Getting patches pushed in our repo without the approbation of one of the person that have write access to our Git repo is definitely something we don't want to happen. I quite agree that having 2 "official" repos is not really a good idea, more because we loose time syncing them but not really because people coming from gnome would be able to push patches without us reviewing.
I'm sorry, I didn't know pitivi doesn't follow usual git.gnome.org rules. I won't push to pitivi directly again.
For the record/to clarify: even among pitivi developers, we tend to have this semi-formal rule of requesting that at least one other dev has reviewed changes before they get pushed to the repo, even if the author has commit access. Peer review :)