After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 656458 - annotationparser: Only accept certain tags
annotationparser: Only accept certain tags
Status: RESOLVED FIXED
Product: gobject-introspection
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gobject-introspection Maintainer(s)
gobject-introspection Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2011-08-13 13:37 UTC by Colin Walters
Modified: 2015-02-07 16:48 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
annotationparser: Only accept certain tags (3.91 KB, patch)
2011-08-13 13:37 UTC, Colin Walters 		committed Details | Review

Description Colin Walters 2011-08-13 13:37:53 UTC 
Previously we were eating any line form "* [A-Za-z]: " as a tag,
but this is a problem since e.g. gtk/gtk/gtkcssprovder.c had literal
CSS e.g. block: which erroneously matched.

Fix this by only accepting particular tags, similar to what gtk-doc
does (although we accept a superset, e.g. transfer too).
Comment 1 Colin Walters 2011-08-13 13:37:55 UTC 
Created attachment 193765 [details] [review]
annotationparser: Only accept certain tags
Comment 2 Johan (not receiving bugmail) Dahlin 2011-08-13 13:41:48 UTC 
Review of attachment 193765 [details] [review]:

Looks great, thanks
Comment 3 Colin Walters 2011-08-13 13:42:33 UTC 
Attachment 193765 [details] pushed as bdeccbd - annotationparser: Only accept certain tags
Comment 4 André Klapper 2015-02-07 16:48:08 UTC 
[Mass-moving gobject-introspection tickets to its own Bugzilla product - see bug 708029. Mass-filter your bugmail for this message: introspection20150207 ]