After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 656415 - Muting microphone issues
Muting microphone issues
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: VoIP
3.1.x
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
Depends on:
Blocks:
 
 
Reported: 2011-08-12 16:53 UTC by Emilio Pozuelo Monfort
Modified: 2011-08-15 08:48 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
CallWindow: fix toggling the microphone on and off (1.71 KB, patch)
2011-08-12 16:54 UTC, Emilio Pozuelo Monfort 		none Details | Review
CallWindow: get the mic volume upon init (1.13 KB, patch)
2011-08-12 16:54 UTC, Emilio Pozuelo Monfort 		none Details | Review

Description Emilio Pozuelo Monfort 2011-08-12 16:53:35 UTC 
We have two regressions with muting the microphone:

a) Call window is created. You mute the mic. If you unmute it, nothing seems to happen (what actually happens is that it unmutes and mutes again).

b) Call window is created. Mic sound is set to, say, 100. You mute the mic. Mic sound is set to 0. You unmute it. Mic sound is still 0 instead of the initial value.

This branch fixes both issues.

http://cgit.collabora.com/git/user/pochu/empathy.git/log/?h=microphone
Comment 1 Emilio Pozuelo Monfort 2011-08-12 16:54:16 UTC 
Created attachment 193715 [details] [review]
CallWindow: fix toggling the microphone on and off

We are changing the GSettings key, and also listening to changes
on it and reacting to them, but we don't want to react to our own
changes!
Comment 2 Emilio Pozuelo Monfort 2011-08-12 16:54:20 UTC 
Created attachment 193716 [details] [review]
CallWindow: get the mic volume upon init

Otherwise it'll be zero and when we unmute the mic, we'll
set the volume to zero as we won't know the old value.
Comment 3 Jonny Lamb 2011-08-15 08:16:00 UTC 
Looks fine to me.
Comment 4 Emilio Pozuelo Monfort 2011-08-15 08:48:08 UTC 
Thanks, merged.