After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 656372 - Wacom tablet-pc-button property needs to be inverted
Wacom tablet-pc-button property needs to be inverted
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: plugins
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2011-08-12 01:29 UTC by Peter Hutterer
Modified: 2011-08-15 10:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
0001-wacom-invert-TPCButton-setting.patch (1.18 KB, patch)
2011-08-12 01:29 UTC, Peter Hutterer 		none Details | Review
0001-wacom-invert-TPCButton-setting.patch (1.12 KB, patch)
2011-08-12 01:47 UTC, Peter Hutterer 		none Details | Review
0001-wacom-invert-TPCButton-setting.patch (1.36 KB, patch)
2011-08-15 01:03 UTC, Peter Hutterer 		committed Details | Review

Description Peter Hutterer 2011-08-12 01:29:29 UTC 
Created attachment 193668 [details] [review]
0001-wacom-invert-TPCButton-setting.patch

Wacom's TPCButton option which this setting emulates is to enable Tablet PC
stylus behaviour when on. The property "Hover Click" works the other way
round, i.e. if Hover Click is _enabled_ this is the equivalent of TPC
behaviour _disabled_.

Bug triggered by commit xf86-input-wacom-0.10.99.1-10-ge0354b9.
Comment 1 Peter Hutterer 2011-08-12 01:47:29 UTC 
Created attachment 193669 [details] [review]
0001-wacom-invert-TPCButton-setting.patch

sorry, had a stale master branch. this one applies on top of 4897bf5c2b194f6772dc0cb654246066f522b6d6
Comment 2 Bastien Nocera 2011-08-12 22:52:56 UTC 
Use your best judgement for those, Peter.

The only code review change would be that the commit message should be there as a comment above the variable assignment, rather than having a very short comment on the same line as the assignment.
Comment 3 Peter Hutterer 2011-08-15 01:03:14 UTC 
Created attachment 193838 [details] [review]
0001-wacom-invert-TPCButton-setting.patch

Updated patch with comment as requested.

Note that: you may bet bug reports for those users on wacom releases prior to 0.11 but this was a rather annoying driver bug that couldn't be fixed easily otherwise. So for those on 0.10.99, the behaviour is inverted until they upgrade.