After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 656328 - [ffdeinterlace] add automatic "mode" property
[ffdeinterlace] add automatic "mode" property
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-libav
0.10.12
Other All
: Normal enhancement
: 0.10.13
Assigned To: GStreamer Maintainers
GStreamer Maintainers
patch
Depends on:
Blocks:
 
 
Reported: 2011-08-11 09:41 UTC by Tvrtko Ursulin
Modified: 2011-09-26 18:24 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch adding mode property to ffdeinterlace (7.08 KB, patch)
2011-08-11 09:42 UTC, Tvrtko Ursulin 		none Details | Review
Patch generated with git format-patch (7.25 KB, patch)
2011-08-12 08:16 UTC, Tvrtko Ursulin 		none Details | Review

Description Tvrtko Ursulin 2011-08-11 09:41:24 UTC 
I did a pretty mechanical (not understanding GStreamer internals and code base that well) patch  porting the mode property from good plugins deinterlace because having this control and also automatic mode is quite convenient for us.

Would something like this be acceptable for merging upstream? At least in principle, I realize patch might have issues. :)
Comment 1 Tvrtko Ursulin 2011-08-11 09:42:00 UTC 
Created attachment 193617 [details] [review]
Patch adding mode property to ffdeinterlace
Comment 2 David Schleef 2011-08-12 00:12:49 UTC 
This is a reasonable direction to go.

Please attach a new patch that is created by 'git format-patch', assuming you're compiling from git.  This makes the patch a lot easier to review.
Comment 3 Tvrtko Ursulin 2011-08-12 08:16:14 UTC 
Created attachment 193676 [details] [review]
Patch generated with git format-patch
Comment 4 David Schleef 2011-08-12 18:52:13 UTC 
Thank you.
Comment 5 Tim-Philipp Müller 2011-09-26 18:24:00 UTC 
This bit looks a bit dodgy to me at first glance

    if (GST_PAD_CAPS (deinterlace->srcpad))
      gst_ffmpegdeinterlace_sink_setcaps (deinterlace->sinkpad,
          GST_PAD_CAPS (deinterlace->sinkpad));

but I guess it doesn't hurt either..


 commit 42cb5bd386f7f4664a104cfaefc53f57e635b246 
 Author: Tvrtko Ursulin <tvrtko.ursulin@onelan.co.uk>
 Date:   Fri Aug 12 09:06:03 2011 +0100

    ffdeinterlace: add "mode" property including automatic mode
    
    Just like deinterlace.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=656328