GNOME Bugzilla – Bug 656306
Cally should use AtkWindow and remove that hack on CallyUtil
Last modified: 2011-08-30 10:53:32 UTC
At this moment when you register a global event listener you can register for Atk events and other kind of events not specified. At this moment, Atk and window events. As this is madness, we decided to allow to just register to Atk events (bug 649577), and in order to do that, implement AtkWindow (638924). This bug is just the migration to that new interface.
Created attachment 193586 [details] [review] CallyStage implementing AtkWindow
Created attachment 193588 [details] [review] We just allow to register atk events now
Created attachment 193589 [details] [review] Now the window events registration should be done asking for the AtkWindow interface
Created attachment 193590 [details] [review] Test doesn't compile This is weird. I needed to make this change because if not, when using an atk with the patches at 638924 I get the error: make[3]: Entering directory `/home/devel/GNOME3/source/clutter/tests/micro-bench' CCLD test-text ../../clutter/.libs/libclutter-glx-1.0.so: undefined reference to `atk_window_get_type' And it is weird because this doesn't happens with other ATK symbols, and as far as I see I'm not doing anything estrange with that atkwindow. But in the same way, not all the tests are failing to compile. So I modified micro-bench and performance tests Makefile.am in order to be more similar to the working ones (LDADD and so on). And in that way seems to work. Further investigation required.
Created attachment 194632 [details] [review] Using AtkWindow on cally stage
Created attachment 194633 [details] [review] We don't need to explicitly manage window events
Created attachment 194634 [details] [review] Updating a11y tests with the proper window format