After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 656295 - gjs: Don't register the gi module until a context is created
gjs: Don't register the gi module until a context is created
Status: RESOLVED FIXED
Product: gjs
Classification: Bindings
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gjs-maint
gjs-maint
Depends on:
Blocks:
 
 
Reported: 2011-08-10 15:47 UTC by Dan Winship
Modified: 2011-08-10 16:48 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gjs: Don't register the gi module until a context is created (1.75 KB, patch)
2011-08-10 15:47 UTC, Dan Winship 		committed Details | Review

Description Dan Winship 2011-08-10 15:47:18 UTC 
gi was moved into libgjs, but was still using
GJS_REGISTER_NATIVE_MODULE(), which was causing gjs_define_gi_stuff()
to be run before main(), which is bad for any number of reasons.

(In particular, this broke log() in gnome-shell, because the gi
initialization code caused the gjs logging framework to be initialized
before gnome-shell got a chance to set GJS_DEBUG_TOPICS.)
Comment 1 Dan Winship 2011-08-10 15:47:20 UTC 
Created attachment 193569 [details] [review]
gjs: Don't register the gi module until a context is created
Comment 2 Colin Walters 2011-08-10 16:35:36 UTC 
Review of attachment 193569 [details] [review]:

I think this is right.
Comment 3 Dan Winship 2011-08-10 16:48:43 UTC 
Attachment 193569 [details] pushed as 1dd3a58 - gjs: Don't register the gi module until a context is created