After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 656282 - GDBusProxy: uninitialized local variables can be freed
GDBusProxy: uninitialized local variables can be freed
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gdbus
2.29.x
Other All
: Normal major
: ---
Assigned To: David Zeuthen (not reading bugmail)
gtkdev
Depends on:
Blocks: 656039
 
 
Reported: 2011-08-10 13:40 UTC by Simon McVittie
Modified: 2011-08-13 20:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (1.52 KB, patch)
2011-08-10 13:40 UTC, Simon McVittie 		none Details | Review

Description Simon McVittie 2011-08-10 13:40:35 UTC 
Created attachment 193547 [details] [review]
patch

In on_properties_changed, if PropertiesChanged is received in the creating thread's thread-default main context at the same time that another thread releases the last ref, two variables are freed (via "goto out") before being initialized.
Comment 1 Cosimo Alfarano 2011-08-11 10:30:48 UTC 
Review of attachment 193547 [details] [review]:

Not reviewer hat but it seems OK; safe change even out of its context.
Comment 2 Matthias Clasen 2011-08-13 20:15:03 UTC 
Thanks. I ended up keeping the initialization separate from the declaration.