GNOME Bugzilla – Bug 656160
[dshowvideosrc] A modified version to fix USB Analog TV Tuner's/DVD Maker capture bug
Last modified: 2018-11-03 13:08:15 UTC
This modified version fixes the issue of dshowvideosrc for capturing USB Analog TV / TV Tuner devices with gstreamer. With IGraphBuilder and ICaptureGraphBuilder2 and the method FindInterface, it correctly builds the upstream filters. In the future it will be interesting to add an input selector for crossbar filters. (Tested on Windows 7 32 bits and Sabrent USB Analog TV with a professional infrared security cam.)
Created attachment 193420 [details] gstdshowvideosrc.cpp, gstdshowvideosrc.h modified, win32 binary dll i posted the binary just for testing, it works with the last OSSbuild binaries 10.6/10.7
Please submit changes in the form of patches, preferably created with 'git format-patch'. Otherwise it's very difficult to review changes.
ok, thanks for the advice, i have a svn version, may i use it to create a patch to? using the diff command ?
(In reply to comment #2) > Please submit changes in the form of patches, preferably created with 'git > format-patch'. Otherwise it's very difficult to review changes. ok, thanks for the advice, i have a svn version, may i use it to create a patch to? using the diff command ?
Yes, a diff would definitely be an improvement
Created attachment 193543 [details] [review] Patch from git format-patch Added Graph Builder and Capture Builder to correctly create upstream needed filters for Analog TV capture devices.
Review of attachment 193543 [details] [review]: The patch looks good to me except for some minor aesthetics changes. I have just tested it an it works great! ::: sys/dshowsrcwrapper/gstdshowvideosrc.cpp @@ +620,3 @@ + The filter graph now is created via the IGraphBuilder Interface + Code added to build upstream filters, needed for USB Analog TV Tuners / DVD Maker, based on AMCap code. + by Fabrice Costa <fabricio.costa@moldeointeractive.com.ar> Copyright notices should go on the top of the file. ::: sys/dshowsrcwrapper/gstdshowvideosrc.h @@ -73,0 +73,5 @@ + IGraphBuilder *graph_builder; + ICaptureGraphBuilder2 *capture_builder; + IAMVideoCompression *pVC; ... 2 more ... The commented lines should be removed if they are not used
Comment on attachment 193543 [details] [review] Patch from git format-patch See Andoni's comments, please update and make sure it applies against latest GIT master and then it can be included
(In reply to comment #9) > (From update of attachment 193543 [details] [review]) > See Andoni's comments, please update and make sure it applies against latest > GIT master and then it can be included Ok, thanks for the comments, i'm checking it right now.
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/43.