Created attachment 193389 [details] [review]
layout: Don't create and destroy ripple animations

Instead, create three ripples and keep tweening them. This gives a dramatic
speedup when entering the overview, but means that we can't have the same animation
running twice. In this case, we "reset" the currently running ripple animation, but
it is hard to notice unless looking for it.

Review of attachment 193389 [details] [review]:

"dramatic"?  It's probably worth mentioning how you measured performance.  Just observation?

Good to commit after comments.

::: js/ui/layout.js
@@ +281,3 @@
+
+        // Cache the three ripples instead of dynamically creating and destroying them
+        // so we don't accidentally cache them.

cache...so we don't accidentally cache?

Seems like you could just delete the second line.

(In reply to comment #2)
> Review of attachment 193389 [details] [review]:
> 
> "dramatic"?  It's probably worth mentioning how you measured performance.  Just
> observation?

I measured performance with my eyes: before, entering and exiting the overview was quite choppy on my nVidia desktop. Now it's extremely smooth.

Attachment 193389 [details] pushed as 08e669a - layout: Don't create and destroy ripple animations