After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 656107 - shmsink should have a buffer-time property.
shmsink should have a buffer-time property.
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal enhancement
: 0.10.23
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-08-07 15:41 UTC by Sjoerd Simons
Modified: 2011-10-12 09:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add ability to tag shmpipes buffers (2.63 KB, patch)
2011-08-07 15:45 UTC, Sjoerd Simons 		needs-work Details | Review
Add buffer-time property to shmsink (4.14 KB, patch)
2011-08-07 15:47 UTC, Sjoerd Simons 		needs-work Details | Review

Description Sjoerd Simons 2011-08-07 15:41:47 UTC 
shmsink should have a buffer-time property similar to pulse-sink :).. Various use-case want to limit the buffering the might happen in the shmsink to be able to minimize worst-case latency..
Comment 1 Sjoerd Simons 2011-08-07 15:45:10 UTC 
Created attachment 193377 [details] [review]
Add ability to tag shmpipes buffers

Add the ability to add a simple uint64 tag to shmpipe buffers, this can be load to store the timestamp for our own booking in the gst element
Comment 2 Sjoerd Simons 2011-08-07 15:47:04 UTC 
Created attachment 193378 [details] [review]
Add buffer-time property to shmsink
Comment 3 Olivier Crête 2011-10-10 22:05:51 UTC 
Review of attachment 193377 [details] [review]:

::: sys/shm/shmpipe.c
@@ +545,2 @@
 int
+sp_writer_send_buf (ShmPipe * self, char *buf, size_t size, uint64_t tag)

Where is this change in shmpipe.h ?
Comment 4 Olivier Crête 2011-10-10 22:18:26 UTC 
Review of attachment 193378 [details] [review]:

::: sys/shm/gstshmsink.c
@@ +168,3 @@
+          "Buffer Time of the shm buffer",
+          "Maximum Size of the shm buffer in nanoseconds",
+          0, G_MAXUINT64, GST_CLOCK_TIME_NONE,

What does GST_CLOCK_TIME_NONE mean? Why not 0 as the default ?
Comment 5 Sjoerd Simons 2011-10-12 07:49:23 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Comment 6 Tim-Philipp Müller 2011-10-12 09:51:04 UTC 
commit 94d9327e2a1d2de75faa3e8f9f8cea10241ad471
Author: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Date:   Sun Aug 7 17:01:48 2011 +0200

    shm: Add buffer-time property
    
    Add a buffer-time property to limit the size of the amount of data
    queued in the shmsink buffer in nanoseconds.
    
    Fixes: #656107