After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 656069 - connect & dcc windows show empty contents (no server and transfer lists)
connect & dcc windows show empty contents (no server and transfer lists)
Status: RESOLVED FIXED
Product: xchat-gnome
Classification: Other
Component: general
HEAD
Other Linux
: Normal major
: ---
Assigned To: xchat-gnome maintainers
xchat-gnome maintainers
Depends on:
Blocks:
 
 
Reported: 2011-08-06 06:04 UTC by Theppitak Karoonboonyanan
Modified: 2011-08-07 13:50 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Reparent widgets (1.58 KB, patch)
2011-08-06 06:12 UTC, Theppitak Karoonboonyanan
committed Details | Review

Description Theppitak Karoonboonyanan 2011-08-06 06:04:55 UTC
As found in Debian #627711 [1], xchat-gnome opens up with empty connect dialog, making it impossible for user to connect to a server.

  [1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=627711

Similar behavior is found in Dcc dialog as well.
Comment 1 Theppitak Karoonboonyanan 2011-08-06 06:12:39 UTC
Created attachment 193340 [details] [review]
Reparent widgets

As the Glade UI designs are only partially used to construct the dialogs, the widgets from Glade UIs should be reparented to the windows created by the instance initializers. Note that simple gtk_container_add() is not sufficient in recent GTK+ versions. They must be reparented (removed from the old parent and then added to the new one).
Comment 2 Ritesh Khadgaray ( irc:ritz) 2011-08-06 17:02:27 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Comment 3 Ritesh Khadgaray ( irc:ritz) 2011-08-06 17:03:05 UTC
Review of attachment 193340 [details] [review]:

committed with minor updates. Thanks.
Comment 4 Ritesh Khadgaray ( irc:ritz) 2011-08-07 13:50:08 UTC
git commit - http://git.gnome.org/browse/xchat-gnome/commit/?id=8f00ec61d7638f8af5f8d90df154c82bb3725c92