After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 656020 - Factor out EmpathyContactChooser from EmpathyInviteParticipantDialog
Factor out EmpathyContactChooser from EmpathyInviteParticipantDialog
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: General
2.33.x
Other Linux
: Normal enhancement
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2011-08-05 10:13 UTC by Guillaume Desmottes
Modified: 2011-08-05 13:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add EmpathyContactChooser (31.48 KB, patch)
2011-08-05 10:14 UTC, Guillaume Desmottes 		committed Details | Review
Move back filtering logic from EmpathyContactChooser to EmpathyInviteParticipantDialog (8.06 KB, patch)
2011-08-05 10:14 UTC, Guillaume Desmottes 		committed Details | Review
Move back selection of the TpContact from the Individual from EmpathyContactChooser to EmpathyInviteParticipantDialog (4.09 KB, patch)
2011-08-05 10:14 UTC, Guillaume Desmottes 		committed Details | Review
EmpathyContactChooser: remove EmpathyTpChat property (4.98 KB, patch)
2011-08-05 10:14 UTC, Guillaume Desmottes 		committed Details | Review

Description Guillaume Desmottes 2011-08-05 10:13:09 UTC 
As part of bug #650861 I refactored EmpathyInviteParticipantDialog to move the contact selection part to its own widget.
Comment 1 Guillaume Desmottes 2011-08-05 10:14:21 UTC 
Created attachment 193298 [details] [review]
Add EmpathyContactChooser

This is a pure code refactoring from EmpathyInviteParticipantDialog, this
widget is not generic yet.
Comment 2 Guillaume Desmottes 2011-08-05 10:14:24 UTC 
Created attachment 193299 [details] [review]
Move back filtering logic from EmpathyContactChooser to EmpathyInviteParticipantDialog
Comment 3 Guillaume Desmottes 2011-08-05 10:14:27 UTC 
Created attachment 193300 [details] [review]
Move back selection of the TpContact from the Individual from EmpathyContactChooser to EmpathyInviteParticipantDialog
Comment 4 Guillaume Desmottes 2011-08-05 10:14:30 UTC 
Created attachment 193301 [details] [review]
EmpathyContactChooser: remove EmpathyTpChat property

It's not used any more and a generic widget shouldn't need it.
Comment 6 Emilio Pozuelo Monfort 2011-08-05 11:08:47 UTC 
+      /* Filter out the contact is we are searching and it doesn't match */

if we are

Your commit messages are too long, you should try to make them less than 60 chars wide or so

Looks good otherwise! Feel free to fix that and merge right away.
Comment 7 Guillaume Desmottes 2011-08-05 13:05:23 UTC 
Attachment 193298 [details] pushed as 820b547 - Add EmpathyContactChooser
Attachment 193301 [details] pushed as 8e839c4 - EmpathyContactChooser: remove EmpathyTpChat property