After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 655920 - Rebase PhoneDetails.numbers upon an AbstractFieldDetails-derived class
Rebase PhoneDetails.numbers upon an AbstractFieldDetails-derived class
Status: RESOLVED FIXED
Product: folks
Classification: Platform
Component: libfolks
git master
Other Linux
: Normal normal
: folks-0.6.0
Assigned To: folks-maint
folks-maint
Depends on:
Blocks: 653684 655911
 
 
Reported: 2011-08-03 17:32 UTC by Travis Reitter
Modified: 2011-08-12 16:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add PhoneFieldDetails (32.84 KB, patch)
2011-08-09 14:35 UTC, Travis Reitter 		accepted-commit_now Details | Review

Description Travis Reitter 2011-08-03 17:32:36 UTC 
Proposed API changes:
-  public abstract Set<FieldDetails> phone_numbers { get; set; }
-  public abstract Set<PhoneFieldDetails> phone_numbers { get; set; }

-  public static bool numbers_equal (string number1, string number2)
+  public override bool equal (AbstractFieldDetails<PhoneFieldDetails> that)
Comment 1 Travis Reitter 2011-08-09 14:35:44 UTC 
Created attachment 193491 [details] [review]
Add PhoneFieldDetails

Bonus patch and relevant patch from branch:

http://cgit.collabora.com/git/user/treitter/folks.git/log/?h=bgo655920-phone-field-details
Comment 2 Philip Withnall 2011-08-10 08:53:19 UTC 
Review of attachment 193491 [details] [review]:

Looks great. I spotted a few small typos, but they can be fixed before committing.

::: folks/phone-details.vala
@@ +25,2 @@
 /**
+ * Object representing a note that can have some parameters associated with it.

s/note/phone number/

@@ +178,3 @@
+   * The phone numbers of the contact.
+   *
+   * A list of phone numbers associated to the contact.

s/associated to/associated with/

::: tests/tracker/match-phone-number.vala
@@ +174,3 @@
           (owned) val);
 
       val = Value (typeof (Set<FieldDetails>));

s/FieldDetails/PhoneFieldDetails/

@@ +190,3 @@
           (owned) val);
 
       val = Value (typeof (Set<FieldDetails>));

s/FieldDetails/PhoneFieldDetails/
Comment 3 Travis Reitter 2011-08-12 16:01:55 UTC 
commit 85d4de54bd7d7e83da6dfc3444dbddf8afe0a016
Author: Travis Reitter <travis.reitter@collabora.co.uk>
Date:   Tue Aug 9 15:59:16 2011 +0200

    Rebase PhoneDetails.phone_numbers upon PhoneFieldDetails
    
    Closes: bgo#655920 - Rebase PhoneDetails.phone_numbers upon an
    AbstractFieldDetails-derived class