GNOME Bugzilla – Bug 655917
Rebase EmailDetails.email_addresses upon an AbstractFieldDetails-derived class
Last modified: 2011-08-12 16:00:50 UTC
Proposed API changes: - public abstract Set<FieldDetails> email_addresses { get; set; } + public abstract Set<EmailFieldDetails> email_addresses { get; set; }
Created attachment 193489 [details] [review] Add EmailFieldDetails Patch from branch: http://cgit.collabora.com/git/user/treitter/folks.git/log/?h=bgo655917-email-field-details
Review of attachment 193489 [details] [review]: A few trivial missing comments, and a type issue to think about (but which we will probably end up not being able to change). ::: NEWS @@ +36,3 @@ +* Bug 655917 — Rebase EmailDetails.email_addresses upon an + AbstractFieldDetails-derived class +* Bug 655374 — Un-break avatar tests Does this really fix bug #655374. ::: backends/eds/lib/edsf-persona-store.vala @@ +865,2 @@ private async void _set_contact_attributes (E.Contact contact, + Set<AbstractFieldDetails<string>> new_attributes, Is it possible to create generic methods in Vala (without making the containing class a generic class)? If so, I think it would be tidier to make _set_contact_attributes() generic, and then change the type of new_attributes to Set<AbstractFieldDetails<T>> instead. ::: backends/tracker/lib/trf-persona-store.vala @@ +859,3 @@ private async void _build_update_query_set ( Tracker.Sparql.Builder builder, + Set<AbstractFieldDetails<string>> properties, Same comment as for EDS' _set_contact_attributes(). @@ +1951,2 @@ internal async void _set_unique_attrib_set (Folks.Persona persona, + Set<AbstractFieldDetails<string>> properties, Trf.Attrib attrib) Same comment as for EDS' _set_contact_attributes(). ::: backends/tracker/lib/trf-persona.vala @@ +108,2 @@ /** * {@inheritDoc} Needs a @since UNRELEASED comment. ::: folks/individual.vala @@ +357,2 @@ /** * {@inheritDoc} Needs a @since UNRELEASED.
commit 9388c1eb0c71735bf750a03248d5f38c96681fd9 Author: Travis Reitter <travis.reitter@collabora.co.uk> Date: Wed Aug 3 13:49:32 2011 -0700 Rebase EmailDetails.email_addresses upon EmailFieldDetails Closes: bgo#655917 - Rebase EmailDetails.email_addresses upon an AbstractFieldDetails-derived class