After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 655867 - [PATCH] register welcome pseudo-session with PAM
[PATCH] register welcome pseudo-session with PAM
Status: RESOLVED FIXED
Product: gdm
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GDM maintainers
GDM maintainers
Depends on:
Blocks:
 
 
Reported: 2011-08-03 03:11 UTC by Lennart Poettering
Modified: 2011-08-30 15:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
the patch (8.16 KB, patch)
2011-08-03 03:11 UTC, Lennart Poettering 		none Details | Review

Description Lennart Poettering 2011-08-03 03:11:31 UTC 
Created attachment 193122 [details] [review]
the patch

In order to get udev/systemd device ACL management right we need to make sure that gdm registers its welcome pseudo-session not only with CK but with PAM, too. The attached patch does this. It's very simple, and hopefully robust. Even on systems not using systemd it should be much cleaner running through the PAM session hooks when setting up the welcome pseudo-session, in order to set additional limits or other rules via PAM.
Comment 1 Ray Strode [halfline] 2011-08-03 15:03:22 UTC 
(In reply to comment #0)
> Created an attachment (id=193122) [details] [review]
> the patch
> 
> In order to get udev/systemd device ACL management right we need to make sure
> that gdm registers its welcome pseudo-session not only with CK but with PAM,
> too. The attached patch does this. It's very simple, and hopefully robust. Even
> on systems not using systemd it should be much cleaner running through the PAM
> session hooks when setting up the welcome pseudo-session, in order to set
> additional limits or other rules via PAM.

If we're going to run through pam anyway, we should consider dropping ck_connector and just relying on pam_ck_connector for the non-systemd case as well.  Although, it may not be flexible enough an interface to do what we need to do, not sure.
Comment 2 Ray Strode [halfline] 2011-08-03 15:08:39 UTC 
Also, I'd rather we go through the existing PAM handling code rather than having new calls to it.
Comment 3 Ray Strode [halfline] 2011-08-30 15:17:21 UTC 
okay, i've committed a, hopefully equivalent, patch to master now:

http://git.gnome.org/browse/gdm/commit/?id=647cad5bf59a4ff3776ba1ae5cda6b1aaaa1cfb2