After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 655819 - Should not distribute autogenerated desktop files
Should not distribute autogenerated desktop files
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: automount
3.1.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2011-08-02 14:39 UTC by Sebastien Bacher
Modified: 2011-08-02 16:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
suggested fix (459 bytes, patch)
2011-08-02 14:42 UTC, Sebastien Bacher 		none Details | Review

Description Sebastien Bacher 2011-08-02 14:39:54 UTC 
The g-s-d 3.1.4 tarball distribute a gnome-fallback-mount-helper.desktop.in which has a newer timestamp than gnome-fallback-mount-helper.desktop.in.in, it will lead to have gnome-fallback-mount-helper.desktop.in not updated during the build and gnome-fallback-mount-helper.desktop to get the command path which was used by whoever disted the tarball

It seems like EXTRA_DIST shouldn't list $(autostart_in_files)?
Comment 1 Sebastien Bacher 2011-08-02 14:42:21 UTC 
Created attachment 193080 [details] [review]
suggested fix
Comment 2 Bastien Nocera 2011-08-02 16:25:13 UTC 
Seeing as you're still marked as a gnome-settings-daemon developer in bugzilla, could you please make sure you create git-formatted patches in the future?

See http://who-t.blogspot.com/2009/06/git-patches-from-tarballs.html if you want to generate those from tarballs.


commit 3f8189bfb0d8429fba1787c20dcf1979c667f89e
Author: Bastien Nocera <hadess@hadess.net>
Date:   Tue Aug 2 17:24:39 2011 +0100

    automount: Don't ship the .in file, just the .in.in one
    
    https://bugzilla.gnome.org/show_bug.cgi?id=655819
Comment 3 Sebastien Bacher 2011-08-02 16:28:53 UTC 
will do next time, thanks!