After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 655769 - Use ZLIB_CFLAGS when compiling gio
Use ZLIB_CFLAGS when compiling gio
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gio
2.29.x
Other Linux
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2011-08-02 06:04 UTC by nospam.kotarou.dono
Modified: 2011-08-03 12:50 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use ZLIB_CFLAGS (329 bytes, patch)
2011-08-02 06:04 UTC, nospam.kotarou.dono 		accepted-commit_now Details | Review

Description nospam.kotarou.dono 2011-08-02 06:04:22 UTC 
Created attachment 193029 [details] [review]
Use ZLIB_CFLAGS

I was building glib with zlib in a nonstandard location but it was erroring while compiling gio because of missing zlib headers. I found it was because it was not passing ZLIB_CFLAGS to gcc so I've added it in Makefile.am with this patch
Comment 1 Colin Walters 2011-08-02 17:51:17 UTC 
Review of attachment 193029 [details] [review]:

Looks fine.
Comment 2 Colin Walters 2011-08-02 19:54:15 UTC 
I need a name to go with your email address for the commit message.
Comment 3 nospam.kotarou.dono 2011-08-03 04:54:13 UTC 
How about just "kotarou"?
Comment 4 Colin Walters 2011-08-03 12:50:14 UTC 
Note we generally dislike anonymous or pseudonym contributions:

http://kerneltrap.org/node/5972

However this is pretty trivial.  I've written a commit message for you and pushed it.

See https://live.gnome.org/GnomeLove/SubmittingPatches for future patches please; thanks!