After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 655739 - add support for libpng version 1.5.x (do not access inside PNG struct directly)
add support for libpng version 1.5.x (do not access inside PNG struct directly)
Status: RESOLVED FIXED
Product: gthumb
Classification: Other
Component: general
2.13.x
Other All
: Normal trivial
: ---
Assigned To: Paolo Bacchilega
Paolo Bacchilega
Depends on:
Blocks:
 
 
Reported: 2011-08-01 17:57 UTC by g.trentalancia
Modified: 2011-08-02 10:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to add support for libpng version 1.5.x to gthumb (879 bytes, patch)
2011-08-01 17:57 UTC, g.trentalancia 		none Details | Review

Description g.trentalancia 2011-08-01 17:57:09 UTC 
Created attachment 192996 [details] [review]
Patch to add support for libpng version 1.5.x to gthumb

gthumb version 2.13.2 and gthumb from git does not build correctly against libpng version 1.5.x.

This is because it is no longer possible to access inside the PNG struct directly.

I am now going to attach a patch (which applies both against git and 2.13.2) which modifies the Cairo PNG extension so that it does not access inside the PNG struct directly.
Comment 1 Paolo Bacchilega 2011-08-02 07:29:25 UTC 
patch pushed to master, thank you.
Comment 2 g.trentalancia 2011-08-02 10:59:37 UTC 
Since libpng 1.5.x is the official release now and it's already at 1.5.4, you should really make a release in my opinion !

Thanks.