After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 655651 - Add GObject introspection support
Add GObject introspection support
Status: RESOLVED FIXED
Product: gcr
Classification: Core
Component: General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME keyring maintainer(s)
GNOME keyring maintainer(s)
: 655653 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2011-07-30 19:28 UTC by Evan Nemerson
Modified: 2019-02-22 11:59 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gcr: add GObject introspection support (2.42 KB, patch)
2011-07-30 19:30 UTC, Evan Nemerson
none Details | Review
gcr: add GObject introspection support (2.64 KB, patch)
2011-07-30 19:34 UTC, Evan Nemerson
none Details | Review
gcr: mark many fields as private (4.59 KB, patch)
2011-07-30 19:37 UTC, Evan Nemerson
none Details | Review
gcr: add GObject introspection support (2.60 KB, patch)
2011-08-03 23:48 UTC, Evan Nemerson
none Details | Review
gcr: add GObject introspection support (2.20 KB, patch)
2011-08-04 04:19 UTC, Evan Nemerson
none Details | Review

Description Evan Nemerson 2011-07-30 19:28:13 UTC
GCR needs a GIR
Comment 1 Evan Nemerson 2011-07-30 19:30:06 UTC
Created attachment 192920 [details] [review]
gcr: add GObject introspection support
Comment 2 Evan Nemerson 2011-07-30 19:34:54 UTC
Created attachment 192921 [details] [review]
gcr: add GObject introspection support

Slightly modified version to add Gcr-3.0.gir and Gcr-3.0.typelib to .gitignore
Comment 3 Evan Nemerson 2011-07-30 19:37:23 UTC
Created attachment 192922 [details] [review]
gcr: mark many fields as private

This will mark some stuff in the API as private.
Comment 4 Evan Nemerson 2011-08-03 23:48:34 UTC
Created attachment 193208 [details] [review]
gcr: add GObject introspection support

Remove the HAVE_INTROSPECTION conditional.
Comment 5 Evan Nemerson 2011-08-04 04:19:38 UTC
Created attachment 193224 [details] [review]
gcr: add GObject introspection support

Instead of using Gcr-@GCR_MAJOR@-@GCR-MINOR@.gir for the name of the GIR, use Gcr-@GCR_MAJOR@-@GCR-MINOR@.gir. This is *probably* more appropriate (unless there are API breaks between minor versions).
Comment 6 Stef Walter 2011-08-11 20:41:46 UTC
Thanks for working on this. Really great!

At the desktop summit, I joined in on the gobject introspection hackfest and worked on this a bit. I committed your patches to a branch:

http://git.gnome.org/browse/gnome-keyring/log/?h=introspection

And added quite a few patches as well. I was mostly offline at the time, so I had a hard time updating this bug.

I don't think we should merge this until we have pretty much most of the g-ir-scanner warnings taken care of. That means:

 * Fixing bugs in gobject-introspection (I've already gotten two bug fixes
   merged at the hackfest)
 * Fixing the gtk doc comments in libgcr and libgck.

In order to do this, I think we should track both the gcr and gck additions in a single bug. So I'll close the other one and track here.

Did I get all your changes in that branch?
Comment 7 Stef Walter 2011-08-11 20:42:47 UTC
*** Bug 655653 has been marked as a duplicate of this bug. ***
Comment 8 Stef Walter 2011-09-29 08:25:39 UTC
Merged into gnome-keyring master.