After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 655635 - GtkScrolledWindows in Notebooks have grey frame on white background
GtkScrolledWindows in Notebooks have grey frame on white background
Status: RESOLVED FIXED
Product: gnome-themes-standard
Classification: Core
Component: Adwaita GTK3 theme
3.1.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-themes-standard-maint
gnome-themes-standard-maint
Depends on:
Blocks:
 
 
Reported: 2011-07-30 13:25 UTC by Colin Guthrie
Modified: 2011-10-25 09:32 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Screenshot showing the result (38.75 KB, image/png)
2011-07-30 13:25 UTC, Colin Guthrie 		  Details
patch (1.20 KB, patch)
2011-10-24 20:59 UTC, Cosimo Cecchi 		none Details | Review

Description Colin Guthrie 2011-07-30 13:25:07 UTC 
Created attachment 192908 [details]
Screenshot showing the result

See the attached screenshot of pavucontrol which uses a Scrolled Window inside a Notebook tab.

If there is something I'm doing wrong, I can adjust pavucontrol, but I figured this is likely a problem with the theme.
Comment 1 Cosimo Cecchi 2011-10-24 20:58:41 UTC 
I investigated this a bit today this afternoon, and I found out there are actually two bugs:
- Adwaita overrides the default background for a notebook, but doesn't make sure viewports inside the notebook get the same background. This is now fixed in git master.
- pavucontrol puts GtkEventBox children into those viewports, which will draw a background themselves by default. You can control this using the visible_window property; see also the documentation for gtk_event_box_set_visible_window().

For the record, I am attaching a patch for pavucontrol to this bug, which together with the fix I committed to gnome-themes-standard, fix the bug completely.
Comment 2 Cosimo Cecchi 2011-10-24 20:59:19 UTC 
Created attachment 199866 [details] [review]
patch
Comment 3 Colin Guthrie 2011-10-25 09:32:49 UTC 
Awesome thanks :)

I tested and committed your fix to pavucontrol now too.

For reference:
Theme fix: http://git.gnome.org/browse/gnome-themes-standard/commit/?id=4888306c315885ae96b67167a03cdbd213e82ed1

PAVUControl fix: http://cgit.freedesktop.org/pulseaudio/pavucontrol/commit/?id=fb278932a429034c3b38c8eb16fa9b9c5017335c