GNOME Bugzilla – Bug 655590
Remove dependency on mx
Last modified: 2012-06-27 11:48:54 UTC
totem is currently in gnome-suites-core-3.2, but it has a dependency on mx which is an unapproved dependency from gnome-apps-3.2. For 3.1.4, we will have to drop totem I guess.
(I moved it to gnome-apps-3.2)
Also totem fails to build against mx 1.2.0 (the one currently provided by jhbuild), but it works against mx 1.3.0. libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../.. -D_REENTRANT -I../../src/gst/ -DG_DISABLE_DEPRECATED -DG_DISABLE_SINGLE_INCLUDES -DATK_DISABLE_DEPRECATED -DATK_DISABLE_SINGLE_INCLUDES -DPANGO_DISABLE_DEPRECATED -DPANGO_DISABLE_SINGLE_INCLUDES -DGDK_DISABLE_DEPRECATED -DGDK_DISABLE_SINGLE_INCLUDES -DGDK_PIXBUF_DISABLE_DEPRECATED -DGDK_PIXBUF_DISABLE_SINGLE_INCLUDES -DGTK_DISABLE_DEPRECATED -DGTK_DISABLE_SINGLE_INCLUDES -DGCONF_DISABLE_DEPRECATED -DGCONF_DISABLE_SINGLE_INCLUDES -DBONOBO_DISABLE_DEPRECATED -DBONOBO_DISABLE_SINGLE_INCLUDES -DBONOBO_UI_DISABLE_DEPRECATED -DBONOBO_UI_DISABLE_SINGLE_INCLUDES -DGNOME_DISABLE_DEPRECATED -DGNOME_DISABLE_SINGLE_INCLUDES -DLIBGLADE_DISABLE_DEPRECATED -DLIBGLADE_DISABLE_SINGLE_INCLUDES -DVTE_DISABLE_DEPRECATED -DVTE_DISABLE_SINGLE_INCLUDES -DGNOME_VFS_DISABLE_DEPRECATED -DGNOME_VFS_DISABLE_SINGLE_INCLUDES -DWNCK_DISABLE_DEPRECATED -DWNCK_DISABLE_SINGLE_INCLUDES -DLIBSOUP_DISABLE_DEPRECATED -DLIBSOUP_DISABLE_SINGLE_INCLUDES -pthread -DGSEAL_ENABLE -D_LARGEFILE64_SOURCE -I/opt/gnome3/include/glib-2.0 -I/opt/gnome3/lib64/glib-2.0/include -I/opt/gnome3/include/gtk-3.0 -I/opt/gnome3/include/atk-1.0 -I/opt/gnome3/include/cairo -I/opt/gnome3/include/gdk-pixbuf-2.0 -I/opt/gnome3/include/pango-1.0 -I/opt/gnome3/include/pixman-1 -I/opt/gnome3/include/totem-pl-parser/1/plparser -I/opt/gnome3/include/gmime-2.4 -I/opt/gnome3/include/gstreamer-0.10 -I/opt/gnome3/include/clutter-gtk-1.0 -I/opt/gnome3/include/clutter-1.0 -I/opt/gnome3/include/cogl -I/opt/gnome3/include/json-glib-1.0 -I/usr/include/freetype2 -I/usr/include/libpng12 -I/usr/include/libdrm -I/usr/include/libxml2 -pthread -DGSEAL_ENABLE -I/opt/gnome3/include/gstreamer-0.10 -I/opt/gnome3/include/glib-2.0 -I/opt/gnome3/lib64/glib-2.0/include -I/opt/gnome3/include/clutter-1.0 -I/opt/gnome3/include/cogl -I/opt/gnome3/include/cairo -I/opt/gnome3/include/atk-1.0 -I/opt/gnome3/include/pango-1.0 -I/opt/gnome3/include/json-glib-1.0 -I/opt/gnome3/include/gdk-pixbuf-2.0 -I/opt/gnome3/include/pixman-1 -I/opt/gnome3/include/clutter-gtk-1.0 -I/opt/gnome3/include/gtk-3.0 -I/opt/gnome3/include/mx-1.0 -I/usr/include/libdrm -I/usr/include/freetype2 -I/usr/include/libpng12 -I/usr/include/libxml2 -pthread -I/opt/gnome3/include/gstreamer-0.10 -I/opt/gnome3/include/glib-2.0 -I/opt/gnome3/lib64/glib-2.0/include -I/usr/include/libxml2 -Wall -Wchar-subscripts -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wpointer-arith -Wcast-align -Wsign-compare -fno-strict-aliasing -g -O2 -MT libbaconvideowidget_la-bacon-video-widget-gst-0.10.lo -MD -MP -MF .deps/libbaconvideowidget_la-bacon-video-widget-gst-0.10.Tpo -c bacon-video-widget-gst-0.10.c -fPIC -DPIC -o .libs/libbaconvideowidget_la-bacon-video-widget-gst-0.10.o In file included from /opt/gnome3/include/mx-1.0/mx/mx-toolbar.h:30:0, from /opt/gnome3/include/mx-1.0/mx/mx-window.h:35, from /opt/gnome3/include/mx-1.0/mx/mx-application.h:31, from /opt/gnome3/include/mx-1.0/mx/mx.h:31, from bacon-video-widget-gst-0.10.c:67: /opt/gnome3/include/mx-1.0/mx/mx-button.h:85:16: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘gchar’ /opt/gnome3/include/mx-1.0/mx/mx-button.h:88:16: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘gchar’ In file included from /opt/gnome3/include/mx-1.0/mx/mx.h:31:0, from bacon-video-widget-gst-0.10.c:67: /opt/gnome3/include/mx-1.0/mx/mx-application.h:118:16: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘GList’ In file included from /opt/gnome3/include/mx-1.0/mx/mx.h:36:0, from bacon-video-widget-gst-0.10.c:67: /opt/gnome3/include/mx-1.0/mx/mx-button-group.h:108:16: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘GSList’ In file included from /opt/gnome3/include/mx-1.0/mx/mx.h:46:0, from bacon-video-widget-gst-0.10.c:67: /opt/gnome3/include/mx-1.0/mx/mx-entry.h:82:16: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘gchar’ /opt/gnome3/include/mx-1.0/mx/mx-entry.h:89:16: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘gchar’ In file included from /opt/gnome3/include/mx-1.0/mx/mx.h:62:0, from bacon-video-widget-gst-0.10.c:67: /opt/gnome3/include/mx-1.0/mx/mx-label.h:77:16: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘gchar’ In file included from /opt/gnome3/include/mx-1.0/mx/mx.h:76:0, from bacon-video-widget-gst-0.10.c:67: /opt/gnome3/include/mx-1.0/mx/mx-stylable.h:73:3: error: expected specifier-qualifier-list before ‘G_CONST_RETURN’ /opt/gnome3/include/mx-1.0/mx/mx-stylable.h:122:16: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘gchar’ /opt/gnome3/include/mx-1.0/mx/mx-stylable.h:126:16: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘gchar’ In file included from /opt/gnome3/include/mx-1.0/mx/mx.h:84:0, from bacon-video-widget-gst-0.10.c:67: /opt/gnome3/include/mx-1.0/mx/mx-tooltip.h:77:16: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘gchar’ /opt/gnome3/include/mx-1.0/mx/mx-tooltip.h:86:16: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘ClutterGeometry’
(In reply to comment #2) > Also totem fails to build against mx 1.2.0 (the one currently provided by > jhbuild), but it works against mx 1.3.0. That's because Mx 1.2.0 hasn't been updated to remove G_CONST_RETURN, I think.
1.2.1 should be enough
Updated jhbuild to use mx 1.2.1 :)
I don't think this should be on the 3.2 blocker. it is not going to get fixed for 3.2, and is not really a big deal.
Matthias, I disagree. The last time I tried it on a virtual machine, totem 3.1 was unable to start due to missing 3d accelerated stuff. The inability to play music or movies seems to me a big deal...
(In reply to comment #7) > Matthias, I disagree. The last time I tried it on a virtual machine, totem 3.1 > was unable to start due to missing 3d accelerated stuff. The inability to play > music or movies seems to me a big deal... This isn't what this bug is about. There won't be a version of Totem that doesn't require Clutter and OpenGL support.
Bastien, I don't understand. Do you mean we (as GNOME community, or you as Totem developers) don't care if people in fallback mode can't play music or videos (unless they install vlc, kde stuff or learn to use gst-launch direclty)?
(In reply to comment #9) > Bastien, I don't understand. Do you mean we (as GNOME community, or you as > Totem developers) don't care if people in fallback mode can't play music or > videos (unless they install vlc, kde stuff or learn to use gst-launch > direclty)? Both. Again, nothing to do with the bug, and if you wanted to complain about this, you should have done so nearly 6 months ago when the change was made in Totem: http://www.hadess.net/2011/04/totem-in-gnome-30-plans-for-32.html
commit f4856b75d7850bd209fe2c7f4e8ebed2ee9a2bab Author: Bastien Nocera <hadess@hadess.net> Date: Wed Jun 27 12:30:55 2012 +0100 build: Remove dependendy on mx https://bugzilla.gnome.org/show_bug.cgi?id=655590 commit 00d564c969db406d8ad173476feed063fc82254f Author: Bastien Nocera <hadess@hadess.net> Date: Wed Jun 27 12:30:33 2012 +0100 backend: Implement aspect frame in raw clutter commit 34ca10f676c6a4eab9aa306c37c4a38364010b15 Author: Bastien Nocera <hadess@hadess.net> Date: Wed Jun 27 12:22:02 2012 +0100 backend: Remove direct calls to Mx functions The logo frame code was non-functional, and the rest could be replaced with totem_aspect_frame_set_child(). commit 06a0a1ab0ff368b36675a3d1a433cf302a8124a9 Author: Bastien Nocera <hadess@hadess.net> Date: Wed Jun 27 12:21:13 2012 +0100 backend: Add _set_child() helper Instead of calling MxBin's. commit ee0cf00527862f4ce5adc557ae453f5cb83a2c59 Author: Bastien Nocera <hadess@hadess.net> Date: Wed Jun 27 12:08:24 2012 +0100 backend: Remove useless class padding commit e3c9abb05bb878461a43f50f4740dece1a1eed4d Author: Bastien Nocera <hadess@hadess.net> Date: Wed Jun 27 12:06:13 2012 +0100 backend: Indentation fixes commit 6291b3634ac5dbd9e7200937f7dea14cea61a566 Author: Bastien Nocera <hadess@hadess.net> Date: Wed Jun 27 11:54:37 2012 +0100 backend: Remove MxPadding checks We always use 0 for padding in all 4 directions. commit 4370dbeb8386385e942cea7fd884f5d740760356 Author: Bastien Nocera <hadess@hadess.net> Date: Wed Jun 27 11:48:32 2012 +0100 backend: Remove unused "ratio" property