After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 655508 - Don't set the current folder while saving a file
Don't set the current folder while saving a file
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks: document-centric
 
 
Reported: 2011-07-28 14:55 UTC by Akshay Gupta
Modified: 2012-07-31 22:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
e-file-chooser: remove persist-key (10.55 KB, patch)
2011-07-30 04:52 UTC, Diego Escalante Urrelo (not reading bugmail) 		committed Details | Review
e-bookmarks-editor: don't set directory (1.07 KB, patch)
2011-07-30 04:52 UTC, Diego Escalante Urrelo (not reading bugmail) 		committed Details | Review

Description Akshay Gupta 2011-07-28 14:55:25 UTC 
Updated guidelines for writing Save dialogs -

Make use of gtk_file_chooser_set_current_name() for File/Save and File/Open and
gtk_file_chooser_set_filename() for File/Save As.

File/Save and File/Open should not use gtk_file_chooser_set_current_folder() to
set folders.

http://people.gnome.org/~federico/news-2011-07.html#recent-folders
Comment 1 Diego Escalante Urrelo (not reading bugmail) 2011-07-30 04:52:26 UTC 
Created attachment 192897 [details] [review]
e-file-chooser: remove persist-key

GTK+ has changed the UX of the GtkFileChooser. This has (pragmatically)
deprecated "last save dir" stored by applications themselves.

For Epiphany this means we no longer need a "persist-key" in our file
chooser, and that we have to clean up some GtkFileChooser API use in
followup patches.

This commit removes the property and uses of it.

Bug #655508
Comment 2 Diego Escalante Urrelo (not reading bugmail) 2011-07-30 04:52:30 UTC 
Created attachment 192898 [details] [review]
e-bookmarks-editor: don't set directory

GTK+ new UX behavior says we shouldn't set the file chooser directory,
recent directories should be listed (automatically) instead.

Bug #655508
Comment 3 Xan Lopez 2011-08-11 16:21:21 UTC 
Review of attachment 192898 [details] [review]:

r=me
Comment 4 Diego Escalante Urrelo (not reading bugmail) 2011-08-11 22:59:35 UTC 
Comment on attachment 192898 [details] [review]
e-bookmarks-editor: don't set directory

Attachment 192898 [details] pushed as a518480 - e-bookmarks-editor: don't set directory
Comment 5 Diego Escalante Urrelo (not reading bugmail) 2011-08-12 00:21:37 UTC 
What about the other one
Comment 6 Xan Lopez 2012-07-31 21:10:45 UTC 
Review of attachment 192897 [details] [review]:

Cool.
Comment 7 Diego Escalante Urrelo (not reading bugmail) 2012-07-31 22:27:58 UTC 
Attachment 192897 [details] pushed as 27a5272 - e-file-chooser: remove persist-key