After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 655486 - Fix declarations of X types in xlib-2.0.gir
Fix declarations of X types in xlib-2.0.gir
Status: RESOLVED FIXED
Product: gobject-introspection
Classification: Platform
Component: general
2.29.x
Other All
: Normal normal
: ---
Assigned To: gobject-introspection Maintainer(s)
gobject-introspection Maintainer(s)
Depends on:
Blocks: 655495
 
 
Reported: 2011-07-28 10:41 UTC by Pavel Holejsovsky
Modified: 2015-02-07 17:01 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fixes xlib types declarations according to X11 headers (3.03 KB, patch)
2011-07-28 10:44 UTC, Pavel Holejsovsky
committed Details | Review

Description Pavel Holejsovsky 2011-07-28 10:41:30 UTC
xlib-2.0.gir contains subset of Xlib types, but all of them are declared as records. In reality, most of them are unsigned long numbers.
Comment 1 Pavel Holejsovsky 2011-07-28 10:44:07 UTC
Created attachment 192808 [details] [review]
Fixes xlib types declarations according to X11 headers
Comment 2 Johan (not receiving bugmail) Dahlin 2011-07-29 12:32:38 UTC
Review of attachment 192808 [details] [review]:

Looks great, this will solve quite a few bugs, for instance showing a gstreamer stream in a drawable.
Comment 3 Pavel Holejsovsky 2011-07-29 13:04:20 UTC
Review of attachment 192808 [details] [review]:

Committed
Comment 4 Pavel Holejsovsky 2011-07-29 13:05:02 UTC
Fixed and committed.
Comment 5 Ray Strode [halfline] 2011-09-07 21:50:19 UTC
fwiw, this was causing very strange error messages and segfaults in gnome-shell until i rebuilt clutter against a version of gobject-introspection with the change.

This is because ClutterX11.gir references the Pixmap type which changed here.

Error messages were like:

Window manager warning: Log level 8: g_function_info_get_flags: assertion `GI_IS_FUNCTION_INFO (info)' failed
Window manager warning: Log level 8: g_callable_info_get_n_args: assertion `GI_IS_CALLABLE_INFO (info)' failed
Window manager warning: Log level 8: g_callable_info_load_return_type: assertion `GI_IS_CALLABLE_INFO (info)' failed
Window manager warning: Log level 8: g_type_info_get_tag: assertion `GI_IS_TYPE_INFO (info)' failed

(to help people searching bugzilla)

there was also a message assertion `G_IS_VALUE (value)' failed from g_value_peek_pointer
Comment 6 André Klapper 2015-02-07 17:01:24 UTC
[Mass-moving gobject-introspection tickets to its own Bugzilla product - see bug 708029. Mass-filter your bugmail for this message: introspection20150207 ]