After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 655432 - Native window placement strategy changes the arrangement of windows if workspace selector is visible
Native window placement strategy changes the arrangement of windows if worksp...
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: extensions
3.0.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-07-27 15:32 UTC by Stefano Facchini
Modified: 2013-05-12 17:27 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Arrangement of windows when workspace selector is hidden (266.98 KB, image/png)
2011-07-27 15:32 UTC, Stefano Facchini
  Details
Arrangement of windows when workspace selector is visible (280.79 KB, image/png)
2011-07-27 15:33 UTC, Stefano Facchini
  Details
Add a gap the the borders keeping the aspect ratio (2.02 KB, patch)
2011-07-27 15:34 UTC, Stefano Facchini
none Details | Review
Tweak the workspace gaps in order to keep the aspect ratio constant (2.46 KB, patch)
2011-07-29 21:57 UTC, Stefano Facchini
none Details | Review

Description Stefano Facchini 2011-07-27 15:32:04 UTC
Native window placement strategy introduces a fixed gap (10px) on the borders of the workspace. In this way, the aspect ratio of the workspace area changes if the workspace selector is visible. This,in turn, leads to a relayout of the window thumbnails every time the visibility of the selector is toggled (see screenshots).

It would be preferable to have the same arrangement in both cases.
Comment 1 Stefano Facchini 2011-07-27 15:32:51 UTC
Created attachment 192760 [details]
Arrangement of windows when workspace selector is hidden
Comment 2 Stefano Facchini 2011-07-27 15:33:27 UTC
Created attachment 192761 [details]
Arrangement of windows when workspace selector is visible
Comment 3 Stefano Facchini 2011-07-27 15:34:44 UTC
Created attachment 192762 [details] [review]
Add a gap the the borders keeping the aspect ratio
Comment 4 wepmaschda 2011-07-28 15:07:49 UTC
Yes, this bug exists. And thanks for analyzing the code!

The 10 px border is mainly inherited from the KDE implementation. Maybe it's not really necessary in the way we use it. 

I haven't tested your patch yet (currently no dev environment), but it looks like an improvement. 

Is it really solving the whole problem? I didn't think the different aspect ratio would be just a problem inside the native-window-placement algorithm. Haven't investigated if the area's aspect ratio itself changes. Doesn't it? (It would make sense, making more space usable).

Anyway I would recommend including the patch. (Can't do more since I have no permissions on the extensions git repository) ;-)
Comment 5 Stefano Facchini 2011-07-29 21:56:08 UTC
(In reply to comment #4)
> Yes, this bug exists. And thanks for analyzing the code!
> 
Thank you for the quick reply!


> The 10 px border is mainly inherited from the KDE implementation. Maybe it's
> not really necessary in the way we use it. 

AFAICS, the only necessary gap is on the right edge of the workspace, in order to prevent the window thumbnails to touch the workspace selector. The gap on the top edge *could* also be a good idea because currently the extension put a label with the window title on the top of the thumbnail which could be half-hidden without a top gap.

However, I just discovered that in the near future the windows decorations in the overview are going to change (see https://bugzilla.gnome.org/show_bug.cgi?id=650254), so probably the title label is not worth thinking about.

In summary, I think that the best solution is a fixed 10px gap on the right, and another vertical gap just to keep the aspect ratio constant.
Comment 6 Stefano Facchini 2011-07-29 21:57:28 UTC
Created attachment 192891 [details] [review]
Tweak the workspace gaps in order to keep the aspect ratio constant
Comment 7 wepmaschda 2012-11-22 19:09:31 UTC
This should be correctly applied in current 3.6 version. Close this bug?
Comment 8 Giovanni Campagna 2013-05-12 17:27:12 UTC
Uhm, I don't know, this bug is quite old. Let's close it.